Skip to content

📦 Add ngrok 3.25.0 release#8

Merged
jwaisner merged 1 commit intomainfrom
3.25.0
Aug 1, 2025
Merged

📦 Add ngrok 3.25.0 release#8
jwaisner merged 1 commit intomainfrom
3.25.0

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Jul 31, 2025

PR Type

Enhancement


Description

  • Add ngrok version 3.25.0 support

  • Update bundle release date to 2025.7.31

  • Add new configuration and release entry


Diagram Walkthrough

flowchart LR
  A["ngrok 3.19.1"] --> B["ngrok 3.25.0"]
  B --> C["Updated Bundle Release"]
  B --> D["New Configuration File"]
  B --> E["Release Registry Entry"]
Loading

File Walkthrough

Relevant files
Configuration changes
bearsampp.conf
Add ngrok 3.25.0 configuration file                                           

bin/ngrok3.25.0/bearsampp.conf

  • Create new configuration file for ngrok 3.25.0
  • Set ngrok version and executable name
  • Define bundle release placeholder
+4/-0     
build.properties
Update bundle release date                                                             

build.properties

  • Update bundle release date from 2025.02.16 to 2025.7.31
+1/-1     
releases.properties
Register ngrok 3.25.0 release                                                       

releases.properties

  • Add new release entry for ngrok 3.25.0
  • Map version to download URL with updated release date
+1/-0     

@N6REJ N6REJ added the enhancement ✨ Improve program label Jul 31, 2025
@qodo-code-review
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Date Format

The bundle release date format changed from YYYY.MM.DD to YYYY.M.DD which creates inconsistency with existing releases and may cause parsing issues

bundle.release = 2025.7.31
bundle.type = tools
URL Consistency

The download URL uses the same date format inconsistency as build.properties, and the release tag format should match the bundle release date format

3.25.0 = https://github.com/Bearsampp/module-ngrok/releases/download/2025.7.31/bearsampp-ngrok-3.25.0-2025.7.31.7z

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Fix inconsistent date format

The date format is inconsistent with existing entries which use dot notation
(2025.02.16). This inconsistency could cause issues with automated processing or
sorting.

build.properties [2]

-bundle.release = 2025.7.31
+bundle.release = 2025.07.31
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies an inconsistent date format in bundle.release compared to the previous format and proposes a fix to improve consistency and maintainability.

Low
  • More

@jwaisner jwaisner merged commit a7aa917 into main Aug 1, 2025
@jwaisner jwaisner deleted the 3.25.0 branch August 1, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants