Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Feb 21, 2025

PR Type

Enhancement, Configuration changes


Description

  • Added configurations for PostgreSQL versions 13.20, 14.17, 15.12, 16.8, and 17.4.

  • Updated build.properties to reflect the new release version.

  • Updated releases.properties with download links for the new PostgreSQL versions.

  • Included initialization scripts and configuration files for each PostgreSQL version.


Changes walkthrough 📝

Relevant files
Configuration changes
22 files
init.bat
Add initialization script for PostgreSQL 13.20                     
+5/-0     
init.bat
Add initialization script for PostgreSQL 14.17                     
+5/-0     
init.bat
Add initialization script for PostgreSQL 15.12                     
+5/-0     
init.bat
Add initialization script for PostgreSQL 16.8                       
+5/-0     
init.bat
Add initialization script for PostgreSQL 17.4                       
+5/-0     
bearsampp.conf
Add configuration file for PostgreSQL 13.20                           
+14/-0   
pg_hba.conf.ber
Add `pg_hba.conf` template for PostgreSQL 13.20                   
+3/-0     
postgresql.conf.ber
Add `postgresql.conf` template for PostgreSQL 13.20           
+35/-0   
bearsampp.conf
Add configuration file for PostgreSQL 14.17                           
+14/-0   
pg_hba.conf.ber
Add `pg_hba.conf` template for PostgreSQL 14.17                   
+3/-0     
postgresql.conf.ber
Add `postgresql.conf` template for PostgreSQL 14.17           
+35/-0   
bearsampp.conf
Add configuration file for PostgreSQL 15.12                           
+14/-0   
pg_hba.conf.ber
Add `pg_hba.conf` template for PostgreSQL 15.12                   
+3/-0     
postgresql.conf.ber
Add `postgresql.conf` template for PostgreSQL 15.12           
+35/-0   
bearsampp.conf
Add configuration file for PostgreSQL 16.8                             
+14/-0   
pg_hba.conf.ber
Add `pg_hba.conf` template for PostgreSQL 16.8                     
+3/-0     
postgresql.conf.ber
Add `postgresql.conf` template for PostgreSQL 16.8             
+35/-0   
bearsampp.conf
Add configuration file for PostgreSQL 17.4                             
+14/-0   
pg_hba.conf.ber
Add `pg_hba.conf` template for PostgreSQL 17.4                     
+3/-0     
postgresql.conf.ber
Add `postgresql.conf` template for PostgreSQL 17.4             
+35/-0   
build.properties
Update release version in build properties                             
+1/-1     
releases.properties
Add download links for new PostgreSQL versions                     
+5/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @N6REJ N6REJ added the Security 🔐 Security issue label Feb 21, 2025
    @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch

    The PostgreSQL version in the configuration file (15.6) does not match the directory name and intended version (15.12)

    postgresqlVersion = "15.6"
    Version Mismatch

    The PostgreSQL version in the configuration file (16.4) does not match the directory name and intended version (16.8)

    postgresqlVersion = "16.4"
    Version Mismatch

    The PostgreSQL version in the configuration file (17.2.3) does not match the directory name and intended version (17.4)

    postgresqlVersion = "17.2.3"

    @qodo-code-review
    Copy link

    qodo-code-review bot commented Feb 21, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix version number mismatch
    Suggestion Impact:The version number was updated from 15.6 to 15.12 in the configuration file exactly as suggested

    code diff:

    -postgresqlVersion = "15.6"
    +postgresqlVersion = "15.12"

    The PostgreSQL version in the configuration file (15.6) does not match the
    actual version in the directory name (15.12). Update the version number to
    match.

    bin/postgresql15.12/bearsampp.conf [1]

    -postgresqlVersion = "15.6"
    +postgresqlVersion = "15.12"

    [Suggestion has been applied]

    Suggestion importance[1-10]: 9

    __

    Why: The version mismatch between directory name (15.12) and configuration (15.6) could cause serious issues with PostgreSQL initialization and operation. This inconsistency needs to be fixed for proper system functionality.

    High
    • Update

    @N6REJ N6REJ merged commit af65d07 into main Feb 22, 2025
    1 check passed
    @N6REJ N6REJ deleted the february branch February 22, 2025 07:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Security 🔐 Security issue

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants