Skip to content

Update php properties from release php-2026.3.4#69

Merged
N6REJ merged 1 commit intomainfrom
update-php-php-2026.3.4
Mar 4, 2026
Merged

Update php properties from release php-2026.3.4#69
N6REJ merged 1 commit intomainfrom
update-php-php-2026.3.4

Conversation

@N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Mar 4, 2026

🤖 Automated Module Properties Update

This PR updates the php.properties file with new versions from release php-2026.3.4.

Changes:

  • Extracted assets starting with php (.7z, .exe, or .zip files)
  • Added version entries with download URLs
  • Maintained semver ordering (newest first)

Release URL: https://github.com/Bearsampp/modules-untouched/releases/tag/php-2026.3.4

Next Steps:

  1. ⏳ Link validation will run automatically
  2. ✅ Once validation passes, this PR will auto-merge
  3. ❌ If validation fails, please review and fix invalid URLs

Auto-generated from release php-2026.3.4
@qodo-code-review
Copy link

Review Summary by Qodo

Add PHP 8.5.3, 8.4.18 and extension updates

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add PHP 8.5.3 and 8.4.18 versions from release php-2026.3.4
• Update php_memcache extension to 8.2-8.5 compatibility
• Update php_imagick extension with nts variant and add 3.7.0
• Update module name reference from ruby to php
Diagram
flowchart LR
  A["PHP Release 2026.3.4"] -->|"Extract Assets"| B["New Versions"]
  B -->|"8.5.3, 8.4.18"| C["php.properties"]
  A -->|"Extension Updates"| D["php_memcache 8.2-8.5"]
  A -->|"Extension Updates"| E["php_imagick 3.7.0 & 3.8.1"]
  D --> C
  E --> C
  F["module_name.txt"] -->|"Update Reference"| G["php"]
Loading

Grey Divider

File Changes

1. module_name.txt ⚙️ Configuration changes +1/-1

Update module name reference

• Changed module name reference from ruby to php

module_name.txt


2. modules/php.properties ✨ Enhancement +5/-2

Add new PHP versions and extension updates

• Added PHP 8.5.3 version from php-2026.3.4 release
• Added PHP 8.4.18 version from php-2026.3.4 release
• Updated php_memcache 8.2 extension from vs16 to vs17 and expanded compatibility to 8.2-8.5
• Updated php_imagick 3.8.1 extension from ts-x86_64 to nts-x86 variant
• Added php_imagick 3.7.0 version for PHP 8.4 compatibility

modules/php.properties


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 4, 2026

Code Review by Qodo

🐞 Bugs (3) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Imagick NTS/x86 package 🐞 Bug ✓ Correctness
Description
The imagick 3.8.1 entry now points to a non-thread-safe (nts) and likely 32-bit (x86) artifact,
conflicting with the repo’s stated preference for thread-safe packages and with adjacent imagick
entries that are ts/x64. This can cause runtime load failures or inconsistent installs for typical
64-bit thread-safe PHP builds.
Code

modules/php.properties[85]

+3.8.1 = https://github.com/Bearsampp/modules-untouched/releases/download/php-2026.3.4/php_imagick-3.8.1-8.5-nts-vs17-x86.zip
Evidence
The repository README explicitly instructs to use thread-safe packages. In php.properties, imagick
3.8.0 and 3.7.0 are thread-safe x64 builds, but 3.8.1 was updated to an nts/x86 build, making it
inconsistent and likely incorrect for expected deployments.

README.md[11-15]
modules/php.properties[85-87]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`modules/php.properties` now references an imagick 3.8.1 artifact that is `nts` and `x86`, conflicting with the repo’s stated requirement/preference to use thread-safe packages and inconsistent with other imagick entries.

### Issue Context
Other imagick entries in the same file are `ts` and `x64`. This entry should likely follow the same build flavor to avoid extension load/runtime problems.

### Fix Focus Areas
- modules/php.properties[85-87]
- README.md[11-15]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Workflow artifact committed 🐞 Bug ⛯ Reliability
Description
This PR changes module_name.txt, which is intended to be a temporary file created by the update
workflow. Because the workflow writes module_name.txt and only deletes it after creating the PR,
automated PRs can repeatedly commit this file, creating noisy diffs and churn.
Code

module_name.txt[1]

+php
Evidence
The update workflow explicitly writes module_name.txt early, uses create-pull-request to commit
changes, and only then runs a cleanup step that removes module_name.txt. Since create-pull-request
will include working tree changes unless constrained, module_name.txt can be committed into PRs (as
happened here).

.github/workflows/update-module-properties.yml[58-71]
.github/workflows/update-module-properties.yml[622-679]
.gitignore[1-26]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`module_name.txt` is a workflow scratch file but is being committed into this PR. This creates noisy diffs and can cause repeated churn in future automated PRs.

### Issue Context
The update workflow writes `module_name.txt`, then creates a PR, then cleans up `module_name.txt`. Since PR creation happens before cleanup, the file can be included in the commit.

### Fix Focus Areas
- .github/workflows/update-module-properties.yml[58-71]
- .github/workflows/update-module-properties.yml[622-679]
- module_name.txt[1-1]
- .gitignore[1-26]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. Memcache vs16/vs17 mismatch 🐞 Bug ⛯ Reliability
Description
The memcache 8.2 entry now points to a vs17 build targeting PHP 8.5 (per filename), while the PHP
8.2 binaries listed in this same file are vs16 builds. If this entry is used with PHP 8.2, it’s at
high risk of ABI/toolchain incompatibility.
Code

modules/php.properties[52]

+8.2 = https://github.com/Bearsampp/modules-untouched/releases/download/php-2026.3.4/php_memcache-8.2-8.5-ts-vs17-x64.zip
Evidence
php.properties shows PHP 8.2 distributions are vs16-x64, but the memcache package is vs17-x64 and
includes '-8.5-' in its filename, indicating it was built for a different PHP/toolchain target. The
automation keys property entries by the first version-like substring in filenames, so updating this
URL replaces whatever previously existed for key '8.2', potentially removing the PHP-8.2-appropriate
memcache build.

modules/php.properties[40-53]
.github/workflows/update-module-properties.yml[380-399]
.github/workflows/update-module-properties.yml[505-525]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The `8.2` memcache URL now references a `vs17` build for `-8.5-`, while PHP 8.2 binaries in this file are `vs16`. This mismatch is risky for PHP 8.2 users.

### Issue Context
The update workflow keys entries by the first version in the filename, so a memcache artifact named `php_memcache-8.2-8.5-...` will always update key `8.2`, potentially overwriting a PHP-8.2-appropriate memcache build.

### Fix Focus Areas
- modules/php.properties[40-53]
- .github/workflows/update-module-properties.yml[380-399]
- .github/workflows/update-module-properties.yml[505-525]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@N6REJ N6REJ merged commit 3527b5e into main Mar 4, 2026
3 checks passed
7.4.30 = https://github.com/Bearsampp/modules-untouched/releases/download/php-7.4.30/php-7.4.30-Win32-vc15-x64.zip
5.6.40 = https://github.com/Bearsampp/modules-untouched/releases/download/php-2022.07.30/php-5.6.40-Win32-VC11-x64.zip
3.8.1 = https://github.com/Bearsampp/modules-untouched/releases/download/php-2026.1.16/php_imagick-3.8.1-8.5-ts-vs17-x86_64.zip
3.8.1 = https://github.com/Bearsampp/modules-untouched/releases/download/php-2026.3.4/php_imagick-3.8.1-8.5-nts-vs17-x86.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Imagick nts/x86 package 🐞 Bug ✓ Correctness

The imagick 3.8.1 entry now points to a non-thread-safe (nts) and likely 32-bit (x86) artifact,
conflicting with the repo’s stated preference for thread-safe packages and with adjacent imagick
entries that are ts/x64. This can cause runtime load failures or inconsistent installs for typical
64-bit thread-safe PHP builds.
Agent Prompt
### Issue description
`modules/php.properties` now references an imagick 3.8.1 artifact that is `nts` and `x86`, conflicting with the repo’s stated requirement/preference to use thread-safe packages and inconsistent with other imagick entries.

### Issue Context
Other imagick entries in the same file are `ts` and `x64`. This entry should likely follow the same build flavor to avoid extension load/runtime problems.

### Fix Focus Areas
- modules/php.properties[85-87]
- README.md[11-15]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant