Skip to content

Conversation

@orbeckst
Copy link
Member

@orbeckst orbeckst commented Sep 1, 2025

Fixes #

Changes made in this Pull Request:

  • use direct assignment instead of setattr
  • moved util.run_residue to gibbs.run_residue

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.34%. Comparing base (1072f38) to head (a4df1e7).
⚠️ Report is 5 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orbeckst orbeckst requested a review from Copilot September 12, 2025 00:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors code to improve readability and organization by replacing setattr calls with direct attribute assignment and relocating a utility function to its appropriate module.

  • Replaced setattr calls with direct assignment (obj.attr = value) for better readability
  • Moved run_residue function from util.py to gibbs.py where it is more appropriately placed
  • Added proper docstring and import statement for the relocated function

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
basicrta/util.py Removed the run_residue function
basicrta/gibbs.py Added run_residue function with documentation and replaced setattr with direct assignment
basicrta/cluster.py Replaced setattr calls with direct attribute assignment
Comments suppressed due to low confidence (1)

basicrta/gibbs.py:1

  • This import statement should be removed since run_residue has been moved to this module and is no longer available in util.py.
import os

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- Updated version number and release date for 1.1.3. 
- added notes on code cleanup changes
@orbeckst orbeckst self-assigned this Sep 12, 2025
@orbeckst orbeckst merged commit 17f970f into main Sep 12, 2025
14 checks passed
@orbeckst orbeckst deleted the refactor-reformat branch September 12, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants