-
Notifications
You must be signed in to change notification settings - Fork 2
code clean up #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code clean up #50
Conversation
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors code to improve readability and organization by replacing setattr calls with direct attribute assignment and relocating a utility function to its appropriate module.
- Replaced
setattrcalls with direct assignment (obj.attr = value) for better readability - Moved
run_residuefunction fromutil.pytogibbs.pywhere it is more appropriately placed - Added proper docstring and import statement for the relocated function
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| basicrta/util.py | Removed the run_residue function |
| basicrta/gibbs.py | Added run_residue function with documentation and replaced setattr with direct assignment |
| basicrta/cluster.py | Replaced setattr calls with direct attribute assignment |
Comments suppressed due to low confidence (1)
basicrta/gibbs.py:1
- This import statement should be removed since
run_residuehas been moved to this module and is no longer available inutil.py.
import os
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Updated version number and release date for 1.1.3. - added notes on code cleanup changes
Fixes #
Changes made in this Pull Request:
PR Checklist