Skip to content

Commit 73d54b7

Browse files
authored
Merge pull request #117 from Becksteinlab/jupyter-error
Accept arbitrary args in signal handler
2 parents d68ed9a + f2ccf08 commit 73d54b7

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ The rules for this file:
2424
### Added
2525

2626
### Fixed
27+
* Changed signal handler method to accept arbitrary args to prevent
28+
error being raised in new jupyter version (Issue #116, PR #117)
2729
* Removed timeout changes during pause/resume for IMDv2 and IMv3
2830
(Issue #96, PR #118)
2931

imdclient/IMDClient.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ def __init__(
7373
continue_after_disconnect=None,
7474
**kwargs,
7575
):
76-
7776
self._stopped = False
7877
self._conn = self._connect_to_server(host, port, socket_bufsize)
7978
self._imdsinfo = self._await_IMD_handshake()
@@ -147,7 +146,7 @@ def __init__(
147146

148147
self._producer.start()
149148

150-
def signal_handler(self):
149+
def signal_handler(self, *args, **kwargs):
151150
"""Catch SIGINT to allow clean shutdown on CTRL+C.
152151
153152
This also ensures that main thread execution doesn't get stuck
@@ -484,7 +483,6 @@ def run(self):
484483
self._buf.notify_producer_finished()
485484

486485
def _expect_header(self, expected_type, expected_value=None):
487-
488486
header = self._get_header()
489487

490488
if header.type != expected_type:
@@ -934,7 +932,6 @@ def notify_consumer_finished(self):
934932

935933

936934
class IMDFrame:
937-
938935
def __init__(self, n_atoms, imdsinfo):
939936
if imdsinfo.time:
940937
self.time = 0.0

0 commit comments

Comments
 (0)