-
Notifications
You must be signed in to change notification settings - Fork 2
IMDReader removed from imdclient #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
8cd4455
imdreader et al removed
amruthesht 95a70fa
Chnages to remove IMDReader
amruthesht fa25049
minimalReader for tests
amruthesht 3c72675
Code Changes
amruthesht 72fa772
Minor changes
amruthesht 9e906f0
Minimal reader and corresponding test-suite clean up
amruthesht fb0d1b7
Chore: `n_atoms` extracted using `mdanalysis`
amruthesht 5485680
Merge branch 'main' into imdreader-split
orbeckst bcf6f7c
Merge branch 'main' into imdreader-split
orbeckst b2bb3c9
Added: `copy` method to `IMDFrame`
amruthesht db10481
Minor changes
amruthesht f387059
Fix: dimensions in IMDFrame
amruthesht 4769c4f
Changes: Removed tests for `dt`
amruthesht 4554ad9
Fix: Change how box dimensions are stored
amruthesht 859b0fe
Fix: `close()` method and fix `wait`-related tests
amruthesht a0cc914
Change: using deepcopy instead and dimensions created by assignment
amruthesht 2afdb82
Fix: minimalReader process_stream behavior to change IMD_WAIT effect
amruthesht 17fadae
Fix: update NAMD input frequency
amruthesht e8e4fc6
Modify/Fix: tests for GROMACS/LAMMPS
amruthesht b4ff92e
Fix: GROMACS/LAMMPS tests for step
amruthesht b8a7cad
Cleanup: Fix small issues in manual tests
amruthesht a108f42
Update docs and imports
jaclark5 abe3488
Update imports
jaclark5 3d4c6a1
Fix: update NAMD steps further
amruthesht 4340015
Fix import
jaclark5 f310986
Fix: PR #64 merge conflicts
amruthesht dfeee77
Add: `minimalReader` usage
amruthesht f2e2e48
Chore: fix dependencies for examples
amruthesht 5b6854b
Change: `minimalReader` chnaged to `MinimalReader`
amruthesht c29c57f
Doc: `MinimalReader` doc update for class
amruthesht 1fa261b
Fix: `pop_full_imdframe` doc comments
amruthesht c12b91d
Chore: Remove example dependencies installation
amruthesht 7bac503
Fix: indentation `index.rst`
amruthesht 12ec780
Chore: Minor clean ups and changes
amruthesht f1a1a6f
Change: `minimalreader`-free examples in `usage.rst` and `examples` d…
amruthesht 3c70b6e
Fix: Lammps topology settings for MDA under examples
amruthesht 282c3ed
Fix: remove `process_stream` under `test_wait_after_disconnect`
amruthesht 17e4f71
Doc: add doc_string for `parse_host_port()`
amruthesht 382fc49
Add: Unit tests for `parse_host_port`
amruthesht 4846157
Add: utils test to GH-CI
amruthesht f34eac6
parse mdp/inp for dt
ljwoods2 73556cc
Merge branch 'main' into test_dt
orbeckst 7662f5b
Merge branch 'main' into imdreader-split
orbeckst ebef779
Merge branch 'main' into imdreader-split
orbeckst 56d18ef
Update: `.toml` to fix dependencies
amruthesht 59b4306
Update: CHANGELOG
amruthesht a329edf
Merge branch 'imdreader-split' into test_dt
ljwoods2 b5bd892
Merge pull request #71 from Becksteinlab/test_dt
ljwoods2 c6d52c2
change "minimalreader" to MinimalReader
ljwoods2 6750a39
fix erroneous merge changes from test_dt branch
ljwoods2 d8bbab9
undo black diffs for test_dt changes
ljwoods2 f1336b2
ReFormat: all files
amruthesht 7c6cb4b
Add: NAMD tests for `dt`
amruthesht 45c4a1d
Chore: Minor cleanup and add checks for tests
amruthesht 158bb4c
remove all assertion guards
ljwoods2 8848d4d
Chore: Minor cleanups
amruthesht 5d063e0
Merge branch 'main' into imdreader-split
orbeckst 0f1f62b
Update: Examples to output simple info
amruthesht cdbbd1c
Add: Added Amruthesh as contributor/maintainer
amruthesht 2eb3425
Apply suggestions from code review
orbeckst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,11 @@ | ||
| name: imdreader-docs | ||
| name: imdclient-docs | ||
| channels: | ||
|
|
||
| - conda-forge | ||
|
|
||
| dependencies: | ||
| # Base depends | ||
| - python | ||
amruthesht marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - pip | ||
|
|
||
| - mdanalysis-sphinx-theme >=1.0.1 | ||
amruthesht marked this conversation as resolved.
Show resolved
Hide resolved
amruthesht marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - pip | ||
| - sphinxcontrib-bibtex | ||
| # Pip-only installs | ||
| #- pip: | ||
| # - pip: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| API Documentation | ||
| ================= | ||
|
|
||
| .. automodule:: imdclient.IMD | ||
| .. automodule:: imdclient.IMDClient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if coverage is correctly reported but this may be something to figure out once this is merged.