-
Notifications
You must be signed in to change notification settings - Fork 2
Add test for incorrect number of atoms error in IMDClient #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa2a0cb
Initial plan
Copilot 0e70677
Add test for incorrect number of atoms error
Copilot 1b73144
Remove code comments as requested
Copilot 17b1ea5
Remove docstrings from new fixtures and tests as requested
Copilot bc25c68
Change u.trajectory.n_atoms to u.atoms.n_atoms as requested
Copilot 57b6b17
Merge branch 'main' into copilot/fix-84
orbeckst e9a030d
Remove port parameter from server_client_incorrect_atoms fixture foll…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge main and then remove port argument (see PR #94 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot complete these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes completed. Removed the port parameter from the fixture and updated it to use server.port instead, following the pattern from PR #94. Also fixed the inconsistent usage of universe.trajectory.n_atoms vs universe.atoms.n_atoms. Commit e9a030d