Skip to content

MAINT: Simplify logic in KineticModel #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nawtrey merged 1 commit into from
Apr 16, 2025
Merged

MAINT: Simplify logic in KineticModel #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions kda/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,16 @@ def __init__(self, K=None, G=None):
RuntimeError
If both ``K`` and ``G`` are ``None``.
"""
if G is None or K is None:
if K is not None:
# if only K is input create the diagram
G = nx.MultiDiGraph()
graph_utils.generate_edges(G=G, vals=K)
elif G is not None:
# if only G is input create the kinetic rate matrix
K = graph_utils.retrieve_rate_matrix(G)
else:
msg = "To create a `KineticModel`, K or G must be input."
raise RuntimeError(msg)
if K is not None:
# if only K is input create the diagram
G = nx.MultiDiGraph()
graph_utils.generate_edges(G=G, vals=K)
elif G is not None:
# if only G is input create the kinetic rate matrix
K = graph_utils.retrieve_rate_matrix(G)
else:
msg = "To create a `KineticModel`, K or G must be input."
raise RuntimeError(msg)

self.K = K
self.G = G
Expand Down