Remove loripsum #29
Remove loripsum #29
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to remove the problematic "loripsum" ADD command from various Dockerfiles to stop the associated errors during builds.
- Comment out the ADD instruction in docker/namd/GPU.Dockerfile
- Comment out the ADD instruction in docker/namd/CPU.Dockerfile
- Comment out the ADD instruction in docker/common/GPU.Dockerfile
- Comment out the ADD instruction in docker/common/CPU.Dockerfile
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker/namd/GPU.Dockerfile | Commented out the ADD instruction for loripsum removal |
| docker/namd/CPU.Dockerfile | Commented out the ADD instruction for loripsum removal |
| docker/common/GPU.Dockerfile | Commented out the ADD instruction for loripsum removal |
| docker/common/CPU.Dockerfile | Commented out the ADD instruction for loripsum removal |
|
|
||
| # bust the docker cache so that we always rerun the installs below | ||
| ADD https://loripsum.net/api /opt/docker/etc/gibberish | ||
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
There was a problem hiding this comment.
[nitpick] Consider removing the commented out ADD instruction entirely if it is no longer needed to reduce code clutter. Alternatively, add a brief comment explaining why it's retained.
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish | |
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish | |
| # Retained as a placeholder for potential future use in cache-busting during development. |
|
|
||
| # bust the docker cache so that we always rerun the installs below | ||
| ADD https://loripsum.net/api /opt/docker/etc/gibberish | ||
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
There was a problem hiding this comment.
[nitpick] Consider removing the commented out ADD instruction entirely if it is no longer needed to reduce code clutter. Alternatively, add a brief comment explaining why it's retained.
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
|
|
||
| # bust the docker cache so that we always rerun the installs below | ||
| ADD https://loripsum.net/api /opt/docker/etc/gibberish | ||
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
There was a problem hiding this comment.
[nitpick] Consider removing the commented out ADD instruction entirely if it is no longer needed to reduce code clutter. Alternatively, add a brief comment explaining why it's retained.
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
|
|
||
| # bust the docker cache so that we always rerun the installs below | ||
| ADD https://loripsum.net/api /opt/docker/etc/gibberish | ||
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
There was a problem hiding this comment.
[nitpick] Consider removing the commented out ADD instruction entirely if it is no longer needed to reduce code clutter. Alternatively, add a brief comment explaining why it's retained.
| # ADD https://loripsum.net/api /opt/docker/etc/gibberish |
Removing/Commenting out
ADD https://loripsum.net/api /opt/docker/etc/gibberishfrom*.Dockerfiledue to ERRORs