Skip to content

Conversation

@andrescevp
Copy link

No description provided.

@mikaelrandy
Copy link
Member

Why not, but as it is strongly recommended to use StatsD through UDP protocol, i'll ask myself about this PR usage.
Technically, all is good, but theoretically, this PR will encourage TCP usage.

Do we really want this ?

ping @omansour

@andrescevp
Copy link
Author

I think that yes, because if the server don't answer we have a issue about the connection, my point is avoid useless waiting time, if the server is down we just discart the information (bad luck, call you sys admin =P)

@omansour
Copy link
Contributor

txs for contributing !

ok, but this value should be a parameter somehow. maybe not used a constant but a property with a default value, and add a setter ?

@mikaelrandy
Copy link
Member

@andrescevp using UDP, you not wait for server response (fire and forget), and you dont have waiting time.

That's why i ask myself about the consequences of this parameter.

@omansour
Copy link
Contributor

we cant just considering this like a regular timeout for those not using udp. But not in a constant :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants