fix: remove --enable flag from codex exec subcommand args

[bluzername]

Problem

Running clink codex fails with this error:

error: unexpected argument '--enable' found
  tip: to pass '--enable' as a value, use '-- --enable'
Usage: codex exec --json --dangerously-bypass-approvals-and-sandbox [PROMPT]

The --enable web_search_request flag in conf/cli_clients/codex.json is a top-level codex flag that must come before the exec subcommand. But because of how clink builds the command (executable + internal_args + config_args), these flags end up after exec:

codex exec --json --dangerously-bypass-approvals-and-sandbox --enable web_search_request "prompt"

The correct order would be:

codex --enable web_search_request exec --json --dangerously-bypass-approvals-and-sandbox "prompt"

This is same root cause as the old #338 issue but with different flag name.

Fix

Removed --enable and web_search_request from the default codex config. Web search is an optional feature and not having it in the config doesnt break any functionality - it just means web search wont be enabled by default (users can still pass it manually).

I chose this approach (option 2 from the issue) instead of adding pre_subcommand_args support because:

• It fixes the immediate breakage with zero risk
• The flag is optional anyway
• Adding pre_subcommand_args would be a larger refactor that touches the registry, models, and command builder

Also updated the test in test_clink_tool.py that was asserting the old args list.

Files changed

• conf/cli_clients/codex.json - removed "--enable" and "web_search_request" from additional_args
• tests/test_clink_tool.py - updated assertion to match new config

Closes #387

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing the clink codex command from executing successfully. By adjusting the default configuration to remove a mispositioned flag, it restores core functionality while maintaining the option for users to manually enable web search. The change is minimal, targeted, and avoids a larger refactor, ensuring immediate stability.

Highlights

• Fixes clink codex execution error: Resolved an issue where running clink codex failed due to the --enable flag being incorrectly positioned after the exec subcommand, leading to an 'unexpected argument' error.
• Removed --enable web_search_request from default config: The --enable web_search_request arguments were removed from conf/cli_clients/codex.json as they are top-level codex flags that must precede the exec subcommand, which was not supported by the current command building mechanism.
• Updated test assertion: The corresponding test in tests/test_clink_tool.py was updated to reflect the modified codex client configuration, ensuring tests pass with the new argument structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the "--enable web_search_request" flag from the codex client configuration in conf/cli_clients/codex.json. This change addresses an issue where the flag was not being correctly interpreted because additional_args are placed after the exec subcommand, while "--enable web_search_request" is a top-level codex flag. The corresponding test in tests/test_clink_tool.py has been updated to reflect this modification. There is no feedback to provide.