feat: Add Codex CLI plugin manifest#421
feat: Add Codex CLI plugin manifest#421internet-dot wants to merge 8 commits intoBeehiveInnovations:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4689dde7cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "command": "uvx", | ||
| "args": [ | ||
| "--from", | ||
| "git+https://github.com/BeehiveInnovations/pal-mcp-server.git", |
There was a problem hiding this comment.
Pin MCP source to an immutable package revision
The MCP launcher pulls pal-mcp-server from a floating Git URL (git+... with no tag/commit), so every new upstream push can change runtime behavior for already-installed plugin versions. That breaks reproducibility (the manifest says 0.1.0, but execution is effectively “latest main”) and can cause sudden regressions or unreviewed code execution in existing installs; use a pinned tag/commit (or a versioned package release) to make plugin behavior deterministic.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Code Review
This pull request introduces the pal-mcp-server integration for Codex, including the necessary plugin manifest, MCP configuration, and documentation. Feedback highlights that the relative path to the MCP configuration in plugin.json is incorrect, the MCP server configuration requires an env section for API keys and pathing, and several files are missing trailing newlines.
| "mcp", | ||
| "codex" | ||
| ], | ||
| "mcpServers": "./.mcp.json", |
There was a problem hiding this comment.
The path to the MCP configuration file appears to be incorrect. Since plugin.json is located in the .codex-plugin/ directory, the relative path ./.mcp.json points to .codex-plugin/.mcp.json. However, the .mcp.json file is located at the repository root. This should be updated to ../.mcp.json to correctly reference the file.
| "mcpServers": "./.mcp.json", | |
| "mcpServers": "../.mcp.json", |
| "command": "uvx", | ||
| "args": [ | ||
| "--from", | ||
| "git+https://github.com/BeehiveInnovations/pal-mcp-server.git@v9.8.2", | ||
| "pal-mcp-server" | ||
| ] |
There was a problem hiding this comment.
The MCP server configuration is missing the env section. The PAL MCP server requires API keys (e.g., GEMINI_API_KEY, OPENAI_API_KEY) to function. Additionally, providing a PATH ensures that uvx and other dependencies can be located correctly across different environments. It is recommended to include these as placeholders in the manifest.
"command": "uvx",
"args": [
"--from",
"git+https://github.com/BeehiveInnovations/pal-mcp-server.git",
"pal-mcp-server"
],
"env": {
"PATH": "/usr/local/bin:/usr/bin:/bin:/opt/homebrew/bin:~/.local/bin",
"GEMINI_API_KEY": "REPLACE_WITH_YOUR_KEY",
"OPENAI_API_KEY": "REPLACE_WITH_YOUR_KEY"
}| ] | ||
| } | ||
| } | ||
| } No newline at end of file |
|
|
||
| ## When to use | ||
| - When you need pal-mcp-server capabilities in your Codex workflow | ||
| - See https://github.com/BeehiveInnovations/pal-mcp-server for full setup instructions No newline at end of file |
There was a problem hiding this comment.
The Markdown file is missing a trailing newline. It is best practice to end all text files with a newline character.
| - See https://github.com/BeehiveInnovations/pal-mcp-server for full setup instructions | |
| - See https://github.com/BeehiveInnovations/pal-mcp-server for full setup instructions | |
Adds a Codex CLI plugin manifest so PAL MCP Server can be installed as a Codex plugin.
What this adds: .codex-plugin/plugin.json, .mcp.json, skills/pal-mcp-server/SKILL.md
Related: awesome-codex-plugins | codex-plugin-scanner