remove unused exceptions

Author: facontidavide

.clang-tidy

@@ -10,18 +10,14 @@ Checks: [
   "performance-*",
   "portability-*",
   "readability-*",
-  "-bugprone-branch-clone",
   "-bugprone-easily-swappable-parameters",
   "-bugprone-narrowing-conversions",
-  "-clang-analyzer-optin.cplusplus.VirtualCall",
   "-cppcoreguidelines-avoid-c-arrays",
   "-cppcoreguidelines-avoid-const-or-ref-data-members",
   "-cppcoreguidelines-avoid-magic-numbers",
   "-cppcoreguidelines-avoid-non-const-global-variables",
-  "-cppcoreguidelines-init-variables",
   "-cppcoreguidelines-narrowing-conversions",
   "-cppcoreguidelines-owning-memory",
-  "-cppcoreguidelines-prefer-member-initializer",
   "-cppcoreguidelines-pro-bounds-array-to-pointer-decay",
   "-cppcoreguidelines-pro-bounds-constant-array-index",
   "-cppcoreguidelines-pro-bounds-pointer-arithmetic",
@@ -32,8 +28,6 @@ Checks: [
   "-cppcoreguidelines-use-default-member-init",
   "-misc-no-recursion",
   "-modernize-avoid-c-arrays",
-  "-modernize-use-default-member-init",
-  "-modernize-use-designated-initializers",
   "-modernize-use-emplace",
   "-performance-avoid-const-params",
   "-performance-avoid-endl",

include/behaviortree_cpp/utils/convert_impl.hpp

@@ -157,7 +157,9 @@ void convertNumber(const SRC& source, DST& target)
   // these conversions are always safe:
   // - same type
   // - float -> double
-  if constexpr(is_same<SRC, DST>() || (is_same<SRC, float>() && is_same<DST, double>()))
+  // - conversion to bool
+  if constexpr(is_same<SRC, DST>() || (is_same<SRC, float>() && is_same<DST, double>()) ||
+               (is_convertible_to_bool<SRC>() && is_same<DST, bool>()))
   {
     // No check needed
     target = static_cast<DST>(source);
@@ -179,11 +181,6 @@ void convertNumber(const SRC& source, DST& target)
     }
     target = static_cast<DST>(source);
   }
-  // special case: bool accept truncation
-  else if constexpr(is_convertible_to_bool<SRC>() && is_same<DST, bool>())
-  {
-    target = static_cast<DST>(source);
-  }
   // casting to/from floating points might cause truncation.
   else if constexpr(std::is_floating_point<SRC>::value ||
                     std::is_floating_point<DST>::value)

include/behaviortree_cpp/utils/wildcards.hpp

@@ -40,7 +40,7 @@ inline bool wildcards_match(std::string_view str, std::string_view pattern)
       return cached == 1;
     }
 
-    bool result;
+    bool result = false;
     if(pattern[j] == '*')
     {
       result = match_ref(match_ref, i, j + 1);

src/xml_parsing.cpp

@@ -148,10 +148,8 @@ struct XMLParser::PImpl
 XMLParser::XMLParser(const BehaviorTreeFactory& factory) : _p(new PImpl(factory))
 {}
 
-XMLParser::XMLParser(XMLParser&& other) noexcept
-{
-  this->_p = std::move(other._p);
-}
+XMLParser::XMLParser(XMLParser&& other) noexcept : _p(std::move(other._p))
+{}
 
 XMLParser& XMLParser::operator=(XMLParser&& other) noexcept
 {
@@ -546,15 +544,7 @@ void VerifyXML(const std::string& xml_text,
           }
         }
       }
-      else if(node_type == NodeType::ACTION)
-      {
-        if(children_count != 0)
-        {
-          ThrowError(line_number, std::string("The node '") + registered_name +
-                                      "' must not have any child");
-        }
-      }
-      else if(node_type == NodeType::CONDITION)
+      else if(node_type == NodeType::ACTION || node_type == NodeType::CONDITION)
       {
         if(children_count != 0)
         {