Fix cmake to add big endian compile option#13
Fix cmake to add big endian compile option#13abioteau wants to merge 1 commit intoBelledonneCommunications:masterfrom
Conversation
abioteau
force-pushed
the
patch-1
branch
2 times, most recently
from
d2a1788 to
8598071
Compare
Without this fix, mediastreamer2 doesn't have this compile option (CMakeLists.txt#L669) with CMake and it might create RTP packet with wrong payload type in header due to markbit field update (src/otherfilters/msrtp.c#L633)
|
Shouldn’t it be fixed in |
|
It should also |
|
I just got an impression from the description that the issue is that the flag does not end up in CMake config and mediastreamer2 subsequently does not pick it automatically. Is |
|
It is absolutely necessary for
|
|
@abioteau Thank you. I wonder if just changing UPD. You are right, without this it is broken. |
barracuda156
left a comment
barracuda156
left a comment
There was a problem hiding this comment.
I can confirm that without this wrong endianness it used.
|
@abioteau You need to rebase it though. |
2 participants
Without this fix, mediastreamer2 doesn't have this compile option (CMakeLists.txt#L669) with CMake and it might create RTP packet with wrong payload type in header due to markbit field update (src/otherfilters/msrtp.c#L633)