Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主题原采用的是 Valine v1.1.7,版本落后严重,且不能和其他主题平滑迁移。
此 PR 升级 Valine 到最新版,可以和其他主体平滑迁移 Valine 评论。
注意事项:
升级后原评论会无法显示,这是因为 Valine v1.1.7 对 path 采用的处理方式是先 url_encode,而后续版本则没有 url_encode 这一步。
解决方法:
目前并没有看到 Valine 有提供解决方案,我的解决方式有些笨拙麻烦,是:去 leancloud 中把所有的 url 列全进行 url_decode 替换处理。