Enable compilation on FreeBSD + clang.#19
Open
cbrueffer wants to merge 1 commit intoBenLangmead:masterfrom
Open
Enable compilation on FreeBSD + clang.#19cbrueffer wants to merge 1 commit intoBenLangmead:masterfrom
cbrueffer wants to merge 1 commit intoBenLangmead:masterfrom
Conversation
junaruga
reviewed
Jul 27, 2020
| CC = gcc | ||
| CPP ?= g++ | ||
| CXX ?= $(CPP) | ||
| CC ?= gcc |
There was a problem hiding this comment.
I think this part is useful. Not only when building by clang but also building by gcc-N compiler.
Collaborator
|
I thought I removed the g++ defaults in bug_fixes. I may have forgotten to commit the changes. |
|
@ch4rr0 You are right. I missed the change in The logic deciding Lines 150 to 152 in 1cc0a45 @cbrueffer , maybe you can run the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.