Fix aar support and move the unpacking out of the wrapper #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
force-pushed
the
fix-aar-support-and-move-the-unpacking-out-of-the-wrapper
branch
from
54e9102 to
4597556
Compare
kateliu20
reviewed
Jan 31, 2025
rules/collect_aar_outputs_aspect.bzl
Outdated
|
|
||
| direct_aars = None | ||
| if hasattr(ctx.rule.attr, "aar"): | ||
| # Collect the direct arr artifact for the given target |
Contributor
There was a problem hiding this comment.
Looks good! just small nit here for the spelling
Bencodes
deleted the
fix-aar-support-and-move-the-unpacking-out-of-the-wrapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of rules_android no longer exports the transitive aar imports as part of the provider. To work around this limitation, and to preserve the existing behavior, I've updated the aspect to collect the transitive aar artifacts in a way that reflects the previous behavior of the upstream provider.
In addition I broke out the AAR unpacking into a genrule which should hopefully improve performance overall by allowing Bazel to manage those actions instead of doing them inside the action.