Note 2014 LTE Android 5.1.1#373
Open
Toxantron wants to merge 2 commits intoBenjamin-Dobell:masterfrom
Toxantron:master
Open
Note 2014 LTE Android 5.1.1#373Toxantron wants to merge 2 commits intoBenjamin-Dobell:masterfrom Toxantron:master
Toxantron wants to merge 2 commits intoBenjamin-Dobell:masterfrom
Toxantron:master
Conversation
Default parameter values in SendPacket and ReceivePacket were leading to confusion in the ReceivePit function. Empty transfer flags were passed in as timeouts. Additionally, on the GS5, empty transfers aren't required around the send ack packets during Pit retrieval, and actually screw up the state breaking the remainder of the session.
This was referenced Nov 6, 2016
Author
|
By reading through the commits sometime around 2014 you included an empty packet into the USB as a bugfix. I am starting to think this was actually a bug introduced by samsung engineers accidentally. They realized a little later and fixed it. Because if you use |
priitpavelson
approved these changes
Dec 23, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By merging sshimko into master I was able to flash TWRP 3.0.2 and install CM-13.0.