JS by BenjaminMichaelis · Pull Request #24 · BenjaminMichaelis/trx-to-vsplaylist

BenjaminMichaelis · 2026-02-22T02:09:30Z

No description provided.

Copilot

Pull request overview

This pull request introduces a JavaScript-based implementation of the TRX to VS Playlist Converter action alongside the existing composite action. The JavaScript action uses Node.js with a pre-install step to set up the trx-to-vsplaylist .NET tool, then runs the conversion in the main step.

Changes:

Adds JavaScript action implementation in js/ directory with pre.js (tool installation) and main.js (conversion logic)
Moves original composite action to composite/ subdirectory to maintain backward compatibility
Updates main action.yml to use the new JavaScript implementation
Updates tests and workflows to reference the composite action explicitly where needed

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
js/src/pre.js	Pre-step script that installs the trx-to-vsplaylist .NET tool
js/src/main.js	Main script that runs the TRX to playlist conversion
js/rollup.config.mjs	Rollup bundler configuration for building the JavaScript action
js/package.json	npm package configuration with dependencies
js/action.yml	Action metadata for the standalone JS action
action.yml	Main action metadata updated to use the JavaScript implementation
composite/action.yml	Original composite action moved to subdirectory
README.md	Documentation updated to reflect JavaScript action as default with composite as legacy option
.github/workflows/update-trx-to-vsplaylist.yml	Workflow updated to reference composite/action.yml
.github/workflows/test.yml	Tests updated to explicitly test both composite and JavaScript implementations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T02:14:02Z

js/src/main.js

+
+    // After running, set outputs similar to the composite action
+    if (separate === 'true') {
+      const playlistFiles = await globAsync('**/*.playlist', { cwd: artifactDir, absolute: true })


Similar to line 8, the glob function in v11 already returns a promise and should not be wrapped with promisify. Use glob directly: const playlistFiles = await glob('**/*.playlist', { cwd: artifactDir, absolute: true })

Copilot · 2026-02-22T02:14:02Z

.github/workflows/update-trx-to-vsplaylist.yml

        run: |
-          sed -i "s/dotnet tool install --global trx-to-vsplaylist --version [0-9.][0-9.]*/dotnet tool install --global trx-to-vsplaylist --version ${{ steps.get_version.outputs.latest }}/g" action.yml
+          sed -i "s/dotnet tool install --global trx-to-vsplaylist --version [0-9.][0-9.]*/dotnet tool install --global trx-to-vsplaylist --version ${{ steps.get_version.outputs.latest }}/g" composite/action.yml



The update workflow now only updates the composite/action.yml file but not the js/src/pre.js file which also has the hardcoded version 1.3.0. The workflow should be updated to also update the version in js/src/pre.js to keep them in sync, or the pre.js should be modified to not hardcode the version.

Suggested change

- name: Update js/src/pre.js with new version

if: steps.check.outputs.update == 'true'

run: |

# Replace the first semantic version occurrence (e.g., 1.3.0) with the latest version

sed -i -E "0,/([0-9]+\.[0-9]+\.[0-9]+)/s//${{ steps.get_version.outputs.latest }}/" js/src/pre.js

Copilot · 2026-02-22T02:14:02Z

README.md

@@ -125,6 +127,30 @@ You can specify multiple outcomes by separating them with commas: `Failed,NotExe

 The generated playlist file is automatically uploaded as a workload artifact.


The README states "The generated playlist file is automatically uploaded as a workload artifact" but the JavaScript action doesn't include artifact upload functionality. This is a discrepancy with the documented behavior. Either update the documentation to clarify that the JS action doesn't upload artifacts automatically and users need to add their own artifact upload step, or implement artifact upload functionality similar to the composite action.

Copilot · 2026-02-22T02:14:03Z

js/src/pre.js

+    const child = exec(command, { windowsHide: true }, (error, stdout, stderr) => {
+      if (stdout) process.stdout.write(stdout)
+      if (stderr) process.stderr.write(stderr)
+      if (error) {
+        reject(error)
+      } else {
+        resolve()
+      }
+    })


The child variable is declared but never used after being assigned. The exec callback handles all the output and error logic, so the child process reference is unnecessary. Remove the 'const child = ' assignment and just call exec directly.

Copilot · 2026-02-22T02:14:03Z

js/src/main.js

+import { promisify } from 'node:util'
+import { glob } from 'glob'
+import { dirname, basename, join } from 'node:path'
+import { existsSync } from 'node:fs'
+
+const globAsync = promisify(glob)
+


The glob package v11 already returns a promise, so wrapping it with promisify is incorrect. The glob function should be used directly without promisify. Change this to directly use the glob function: const trxFiles = await glob(trxPattern) and remove the promisify import and this line.

Suggested change

import { promisify } from 'node:util'

import { glob } from 'glob'

import { dirname, basename, join } from 'node:path'

import { existsSync } from 'node:fs'

const globAsync = promisify(glob)

import { glob } from 'glob'

import { dirname, basename, join } from 'node:path'

import { existsSync } from 'node:fs'

Copilot · 2026-02-22T02:14:03Z

js/src/main.js

+    if (outputDirectory) {
+      artifactDir = outputDirectory
+    } else {
+      artifactDir = dirname(trxFiles[0])
+    }


When an output directory is specified by the user, it should be created if it doesn't exist, similar to how the composite action uses mkdir -p. Without this, the action will fail if the user specifies a non-existent directory. Add a check to create the directory using Node.js fs.mkdirSync with recursive option when outputDirectory is provided.

Copilot · 2026-02-22T02:14:03Z

js/src/pre.js

+async function run() {
+  try {
+    core.info('Setting up .NET and installing trx-to-vsplaylist tool (pre step)...')
+
+    // Match the composite action: setup .NET 10.x GA and install the tool globally
+    await runCommand('dotnet --info')
+
+    await runCommand('dotnet tool install --global trx-to-vsplaylist --version 1.3.0 --source https://api.nuget.org/v3/index.json')


The pre.js runs dotnet --info and installs the .NET tool without first setting up .NET, unlike the composite action which uses actions/setup-dotnet@v5 to set up .NET 10.x. If the GitHub Actions runner doesn't have .NET installed or has an incompatible version, this will fail. Consider documenting this requirement or adding logic to handle missing .NET installations gracefully.

Suggested change

async function run() {

try {

core.info('Setting up .NET and installing trx-to-vsplaylist tool (pre step)...')

// Match the composite action: setup .NET 10.x GA and install the tool globally

await runCommand('dotnet --info')

await runCommand('dotnet tool install --global trx-to-vsplaylist --version 1.3.0 --source https://api.nuget.org/v3/index.json')

async function ensureDotnetAvailable(): Promise<boolean> {

try {

await runCommand('dotnet --info')

return true

} catch (error) {

// Handle the specific case where the dotnet executable is not found.

if (error && typeof error === 'object' && 'code' in error && error.code === 'ENOENT') {

core.setFailed(

'`.NET (dotnet)` is not installed or not available on PATH. ' +

'Please add an `actions/setup-dotnet@v5` step to your workflow to install .NET 10.x before this action runs.'

)

return false

}

throw error

}

}

async function run() {

try {

core.info('Setting up .NET and installing trx-to-vsplaylist tool (pre step)...')

// Ensure dotnet is available before proceeding with tool installation

const hasDotnet = await ensureDotnetAvailable()

if (!hasDotnet) {

return

}

await runCommand(

'dotnet tool install --global trx-to-vsplaylist --version 1.3.0 --source https://api.nuget.org/v3/index.json'

)

Copilot · 2026-02-22T02:14:03Z

js/src/main.js

+import { promisify } from 'node:util'
+import { glob } from 'glob'
+import { dirname, basename, join } from 'node:path'
+import { existsSync } from 'node:fs'
+
+const globAsync = promisify(glob)
+


The promisify import is no longer needed since glob v11 already returns promises. This import should be removed along with the globAsync promisification on line 8.

Suggested change

import { promisify } from 'node:util'

import { glob } from 'glob'

import { dirname, basename, join } from 'node:path'

import { existsSync } from 'node:fs'

const globAsync = promisify(glob)

import { glob } from 'glob'

import { dirname, basename, join } from 'node:path'

import { existsSync } from 'node:fs'

Copilot · 2026-02-22T02:14:03Z

.github/workflows/test.yml

          </TestRun>
          EOF

-      - name: Test Action - Merge multi-framework results
+      - name: Test Action - Merge multi-framework results (JS default)
        uses: ./
        with:
          trx-file-path: './TestResults/net*.trx'


The test passes an 'artifact-name' input to the JS action, but this input is not defined in js/action.yml or action.yml. The JS action only supports the inputs: trx-file-path, output-directory, test-outcomes, skip-empty, and separate. This test should either remove the artifact-name parameter or the JS action should support it if artifact upload functionality is added.

Copilot · 2026-02-22T02:14:04Z

.github/workflows/test.yml

            exit 1
          fi

-      - name: Test Action - Separate multi-framework results
+      - name: Test Action - Separate multi-framework results (JS default)
        uses: ./
        with:
          trx-file-path: './TestResults/net*.trx'


The test passes an 'artifact-name' input to the JS action, but this input is not defined in js/action.yml or action.yml. The JS action only supports the inputs: trx-file-path, output-directory, test-outcomes, skip-empty, and separate. Remove the artifact-name parameter from this test.

JS

9716824

Copilot AI review requested due to automatic review settings February 22, 2026 02:09

Copilot started reviewing on behalf of BenjaminMichaelis February 22, 2026 02:09 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS#24

JS#24
BenjaminMichaelis wants to merge 1 commit intomainfrom
bmichaelis/pre

BenjaminMichaelis commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

+      - name: Update js/src/pre.js with new version
+        if: steps.check.outputs.update == 'true'
+        run: |
+          # Replace the first semantic version occurrence (e.g., 1.3.0) with the latest version
+          sed -i -E "0,/([0-9]+\.[0-9]+\.[0-9]+)/s//${{ steps.get_version.outputs.latest }}/" js/src/pre.js

		@@ -125,6 +127,30 @@ You can specify multiple outcomes by separating them with commas: `Failed,NotExe

		The generated playlist file is automatically uploaded as a workload artifact.

-async function run() {
-  try {
-    core.info('Setting up .NET and installing trx-to-vsplaylist tool (pre step)...')
-    // Match the composite action: setup .NET 10.x GA and install the tool globally
-    await runCommand('dotnet --info')
-    await runCommand('dotnet tool install --global trx-to-vsplaylist --version 1.3.0 --source https://api.nuget.org/v3/index.json')
+async function ensureDotnetAvailable(): Promise<boolean> {
+  try {
+    await runCommand('dotnet --info')
+    return true
+  } catch (error) {
+    // Handle the specific case where the dotnet executable is not found.
+    if (error && typeof error === 'object' && 'code' in error && error.code === 'ENOENT') {
+      core.setFailed(
+        '`.NET (dotnet)` is not installed or not available on PATH. ' +
+          'Please add an `actions/setup-dotnet@v5` step to your workflow to install .NET 10.x before this action runs.'
+      )
+      return false
+    }
+    throw error
+  }
+}
+async function run() {
+  try {
+    core.info('Setting up .NET and installing trx-to-vsplaylist tool (pre step)...')
+    // Ensure dotnet is available before proceeding with tool installation
+    const hasDotnet = await ensureDotnetAvailable()
+    if (!hasDotnet) {
+      return
+    }
+    await runCommand(
+      'dotnet tool install --global trx-to-vsplaylist --version 1.3.0 --source https://api.nuget.org/v3/index.json'
+    )

Conversation

BenjaminMichaelis commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants