Add generic Map API for addon web-map integration#2885
Merged
tastybento merged 1 commit intodevelopfrom Mar 23, 2026
Merged
Conversation
Introduce MapHook abstract class and MapManager facade so addons can create markers, areas, and polygons without depending on a specific map plugin. MapManager fans out calls to all active map hooks (BlueMap, Dynmap, etc.) and silently no-ops when none are installed. Both BlueMapHook and DynmapHook now extend MapHook. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
MapHookabstract class (api/hooks/) defining a common contract for web-map plugins: marker sets, point markers, area markers, and polygon markers using only JDK/Bukkit types (java.awt.Color,Location,World)MapManagerfacade (managers/) that fans out calls to all activeMapHookimplementations, with try-catch isolation per hook and silent no-op when no map plugins are installedBlueMapHookandDynmapHookto extendMapHookinstead ofHookMapManagerintoBentoBox.java— addons access it viaBentoBox.getInstance().getMapManager()getBlueMapAPI(),getMarkerAPI()) remain for direct access when neededAddon usage example
Test plan
MapManagerTest— fan-out to multiple hooks, silent no-op, exception isolation (14 tests)BlueMapHookTest— existing + new abstract method tests (21 tests)DynmapHookTest— existing + updated API tests (20 tests)🤖 Generated with Claude Code