Reorder a GarbageCollector::RunFinalizer signature to fix matching on SVS#196
Closed
y0soro wants to merge 1 commit intoBepInEx:masterfrom
Closed
Reorder a GarbageCollector::RunFinalizer signature to fix matching on SVS#196y0soro wants to merge 1 commit intoBepInEx:masterfrom
y0soro wants to merge 1 commit intoBepInEx:masterfrom
Conversation
… SVS The "Test Game" signature is a bit general that it matched `MS.Internal.Xml.Cache.XPathDocumentNavigator` in Summer Vacation! Scramble(SVS) assembly. The "V Rising" signature is the one actually matched RunFinalizer in SVS, so reorder this signature before the "Test Game" one. Also add a comment for "Test Game" signature that matched on HoneyCome and DigitalCraft.
ds5678
approved these changes
Dec 30, 2024
Collaborator
ds5678
left a comment
ds5678
left a comment
There was a problem hiding this comment.
Seems fine, but I want someone else to review it, too.
Contributor
Author
|
Closing this as I think a more specific signature should be added for "Test Game" even with #199, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Test Game" signature is a bit general that it matched
MS.Internal.Xml.Cache.XPathDocumentNavigatorin Summer Vacation! Scramble(SVS) assembly.The "V Rising" signature is the one actually matched RunFinalizer in SVS, so reorder this signature before the "Test Game" one.
Also add a comment for "Test Game" signature that matched on HoneyCome and DigitalCraft.
Tested working on SVS, DC and HC with this order.