Added option for custom http port to avoid conflicts & 'end' ethernet type for HA Yellow hardware#96
Open
Tmp2k wants to merge 5 commits intoBepacom-Raalte:mainfrom
Open
Added option for custom http port to avoid conflicts & 'end' ethernet type for HA Yellow hardware#96Tmp2k wants to merge 5 commits intoBepacom-Raalte:mainfrom
Tmp2k wants to merge 5 commits intoBepacom-Raalte:mainfrom
Conversation
…configuration files
…ions in builder and lint configurations
…n and configuration files
- Introduced `ingress_port` configuration option to allow changing the default ingress web UI port (previously hard-coded to 8099). - Updated documentation and configuration files to reflect the new option and its default behavior. - Adjusted references to the ingress port in various files to ensure consistency.
…efensive checks for duplicate device instances and KeyError handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable
ingress_portoption (default 8099) to thebacnetinterfaceHome Assistant add-on, replacing the previously hard‑coded external ingress listen port.Adds 'end' ethernet type for HA Yellow hardware.
Also prepares this fork (
NemiahUKrepo) for local build/testing by:NemiahUKnamespaceKey Changes
New
config.yaml: Addedingress_portunderoptionswith schemaingress_port: int(1,65535)?(default 8099).rootfs/etc/nginx/templates/ingress.gtpl: Now conditionallylisten {{ .ingress_port }}else fallback tolisten 8099;.Docs & Translations
DOCS.md: New section describingingress_port; clarified legacy meaning of80/tcp.README.md: Note about configurable ingress port.translations/en.yaml&translations/nl.yaml: Updated wording to steer users towardingress_port.Repository / Build Adjustments
NemiahUKequivalents for testability.Files Touched
bacnetinterface/config.yamlbacnetinterface/rootfs/etc/nginx/templates/ingress.gtplbacnetinterface/DOCS.mdbacnetinterface/README.mdbacnetinterface/CHANGELOG.mdbacnetinterface/translations/en.yamlbacnetinterface/translations/nl.yaml(No Python service code changes required; FastAPI still binds to internal
127.0.0.1:7813.)Rationale
Hard‑coded ingress port (8099) caused conflicts on some hosts. Making it configurable preserves backward compatibility while enabling flexibility. Fork adjustments allow validation and integration from this repository without upstream CI/image dependencies.
Backward Compatibility
ingress_port: behavior identical (still 8099).ingress_port: NGINX listens on supplied value.Upstream Maintainer Actions (When Merging Back)
nemiahuk=>bepacom-raalteandNemiahUK=>Bepacom-Raalte).ingress_port.