Skip to content

Added option for custom http port to avoid conflicts & 'end' ethernet type for HA Yellow hardware#96

Open
Tmp2k wants to merge 5 commits intoBepacom-Raalte:mainfrom
NemiahUK:main
Open

Added option for custom http port to avoid conflicts & 'end' ethernet type for HA Yellow hardware#96
Tmp2k wants to merge 5 commits intoBepacom-Raalte:mainfrom
NemiahUK:main

Conversation

@Tmp2k
Copy link

@Tmp2k Tmp2k commented Sep 25, 2025

Summary

Adds a configurable ingress_port option (default 8099) to the bacnetinterface Home Assistant add-on, replacing the previously hard‑coded external ingress listen port.

Adds 'end' ethernet type for HA Yellow hardware.

Also prepares this fork (NemiahUK repo) for local build/testing by:

  • Disabling GitHub Actions workflows (so HA Supervisor builds locally instead of pulling a remote image)
  • Removing use of the previously referenced external pre-built image (local Docker build is now authoritative)
  • Repointing repository/documentation links from the original upstream to the NemiahUK namespace

Key Changes

New

  • config.yaml: Added ingress_port under options with schema ingress_port: int(1,65535)? (default 8099).
  • rootfs/etc/nginx/templates/ingress.gtpl: Now conditionally listen {{ .ingress_port }} else fallback to listen 8099;.

Docs & Translations

  • DOCS.md: New section describing ingress_port; clarified legacy meaning of 80/tcp.
  • README.md: Note about configurable ingress port.
  • translations/en.yaml & translations/nl.yaml: Updated wording to steer users toward ingress_port.

Repository / Build Adjustments

  • All upstream repo references swapped to NemiahUK equivalents for testability.
  • GitHub workflow scripts disabled.
  • External image usage removed so Home Assistant builds locally.

Files Touched

  • bacnetinterface/config.yaml
  • bacnetinterface/rootfs/etc/nginx/templates/ingress.gtpl
  • bacnetinterface/DOCS.md
  • bacnetinterface/README.md
  • bacnetinterface/CHANGELOG.md
  • bacnetinterface/translations/en.yaml
  • bacnetinterface/translations/nl.yaml

(No Python service code changes required; FastAPI still binds to internal 127.0.0.1:7813.)


Rationale

Hard‑coded ingress port (8099) caused conflicts on some hosts. Making it configurable preserves backward compatibility while enabling flexibility. Fork adjustments allow validation and integration from this repository without upstream CI/image dependencies.


Backward Compatibility

  • Omit ingress_port: behavior identical (still 8099).
  • Set ingress_port: NGINX listens on supplied value.
  • Internal FastAPI port unchanged; no schema breaking change.

Upstream Maintainer Actions (When Merging Back)

  1. Restore original repository URLs etc. (nemiahuk => bepacom-raalte and NemiahUK => Bepacom-Raalte).
  2. Re-enable GitHub Actions workflows.
  3. Reintroduce remote/pre-built image usage if still desired in release pipeline.
  4. (Optional) Update integration docs to mention ingress_port.

- Introduced `ingress_port` configuration option to allow changing the default ingress web UI port (previously hard-coded to 8099).
- Updated documentation and configuration files to reflect the new option and its default behavior.
- Adjusted references to the ingress port in various files to ensure consistency.
…efensive checks for duplicate device instances and KeyError handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant