Add: Lsm6dsv16x high end smartphone IMU with qvar support.#396
Merged
Add: Lsm6dsv16x high end smartphone IMU with qvar support.#396
Conversation
ducky64
reviewed
Mar 19, 2025
Collaborator
ducky64
left a comment
ducky64
left a comment
There was a problem hiding this comment.
Mostly looks good! Just one note about current draw and a question on qvar port typing.
Add: port doc note for push-pull/open-drain
ducky64
approved these changes
Mar 19, 2025
Collaborator
ducky64
left a comment
ducky64
left a comment
There was a problem hiding this comment.
Looks good!
One nit: consider merging the doc about push-pull / open-drain into the doc in the wrapper class. The wrapper class is going to be more visible and that doc is probably the one that will be read.
Feel free to merge whenever.
Update: Formate styling
Collaborator
Author
|
Okay, I moved the doc comments to the wrapper side and merging now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Lsm6dsv16x high end smartphone IMU.
Very similar and electrically compatible with Imu_Lsm6ds3trc, but this chip has extended voltage range and lower power consumptions.
Additional two pins are for qvar sensing.
Datasheet