fix(ollama/chat): correctly map reasoning_effort to think in requests #15186
+18
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(ollama/chat): correctly map reasoning_effort to think in requests
Relevant issues
Fixes #15059
Fixes #11680 (#11680 (comment))
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/
directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit
Type
🐛 Bug Fix
Changes
Parameter mapping improvements:
Updated
map_openai_params
in both chat/transformation.py and completion/transformation.py so thereasoning_effort
parameter maps directly to the Ollamathink
param (high/medium/low) instead of always defaulting to True. As in ollama/ollama-python@aa4b476 and ollama/ollama#11752.Parameter mapping correction:
pop the
think
parameter fromoptional_params
, so that it maps correctly to ollama API https://github.com/ollama/ollama/blob/main/docs/api.md, fixes the warninglevel=WARN source=types.go:737 msg="invalid option provided" option=think
Effect
Before this PR:
reasoning_content
is missing from output, indicating thatthink
param is not mapped correctly:#15059
With this PR:
reasoning_content
is return correctly.Testing Pass
Gemini and Cohere related test should not be affected in this PR