Adding support for OCI exception mapping logic in Litellm #17390
+269
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i exception mapping
…ke line length violations and inline comments.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ated to HTTP 409 code for OCI error mapping update, added ConflictError to list of exception types
…t from exceptions.py as part of test case for added logic in PR
Author
|
| _message += f", LiteLLM Max Retries: {self.max_retries}" | ||
| return _message | ||
|
|
||
| class ConflictError(openai.ConflictError): # type: ignore |
Contributor
There was a problem hiding this comment.
this seems like a new exception - what version of openai is required for this?
Author
There was a problem hiding this comment.
Version 2.8.1
python -c "import openai; print(openai.version); print(hasattr(openai, 'ConflictError'))"
2.8.1
True
It is also documented here https://platform.openai.com/docs/guides/error-codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for OCI exception mapping logic in Litellm
Relevant issues
In testing LiteLLM with OCI, error mapping is not occurring as expected. Errors are returned wrapped in a LiteLLM 500 error by the LiteLLM exception_mapping_utils. py file. This includes when errors are actually 401, 404, 429, and other errors as returned by OCI they are wrapped in a 500 LiteLLM error. This can lead to misleading developers and users of the actual issue occurring.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
✅ Test
Changes
Added exception mapping functions and logic specifically for OCI in the oci_exception_mapping_utils.py file in the same style as other providers. Added the test files in the tests directory per the contributing hard requirement checklist..