Include repo object when templating#303
Open
kenodegard wants to merge 6 commits intoBetaHuhn:masterfrom
Open
Conversation
Author
|
@BetaHuhn will you have time to review this soon? |
BetaHuhn
reviewed
May 5, 2024
src/git.js
Outdated
Owner
There was a problem hiding this comment.
@kenodegard why are these changes to the git.js file necessary?
Author
There was a problem hiding this comment.
I can't remember, but it wouldn't appear necessary and can be reverted
8c82d01 to
2da9fa8
Compare
|
Hi, Any update for this great feature ? |
|
Hi @BetaHuhn Any updates? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the
repoobject to every Nunjucks context for easier bulk templating.The way templating is currently defined makes it very verbose to template several repos, especially when trying to do relatively simple templating like injecting the repo name. We'd effectively need:
By pre-populating the context with the repo object we are able to simplify it and do the following instead: