Skip to content

Fix release artifact naming #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandima-d merged 1 commit into from
May 21, 2025
Merged

Fix release artifact naming #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
run: |
# Create release with all course artifacts
gh release create ${{ github.ref_name }} \
json-outputs-experience-${{ env.COURSE_VERSION }}.zip \
json-outputs-bc-${{ env.COURSE_VERSION }}.zip \
json-outputs-bc-ai-${{ env.COURSE_VERSION }}.zip \
--title ${{ github.ref_name }}
env:
Expand Down
14 changes: 9 additions & 5 deletions bin/zip-outputs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@

# Check if a course name was provided
if [ -z "$2" ]; then
# No course specified, zip all courses separately
zip -r json-outputs-experience-$1.zip json-outputs/experience-$1
zip -r json-outputs-bc-ai-$1.zip json-outputs/bc-ai-$1
# No specific course supplied. Zip any directories produced by
# `bin/make-release` that match the version suffix.
for dir in json-outputs/*-$1; do
[ -d "$dir" ] || continue
base=$(basename "$dir")
zip -r "json-outputs-$base.zip" "$dir"
done
else
# Zip specific course
# Zip only the requested course directory
course_name=$2
zip -r json-outputs-$course_name-$1.zip json-outputs/$course_name-$1
zip -r "json-outputs-${course_name}-$1.zip" "json-outputs/${course_name}-$1"
fi