Conversation
sync across host/containers
stays in: - binaries - healthcheck; changes to this would usually be shipped with a new vector version => new image anyway - default vector scaffolding so it doesn't crash
|
Thanks @paweljw! 💄: Could you nest the files for |
|
Any changes needed to Kubernetes configs? E.g. https://github.com/BetterStackHQ/collector-helm-chart/blob/main/templates/daemonset.yaml#L146 |
curusarn
left a comment
There was a problem hiding this comment.
Left a comment, looks good 👍
docker-compose.yml
Outdated
| - letsencrypt:/etc/letsencrypt | ||
| - ssl-certs:/etc/ssl | ||
| - /var/lib/better-stack:/var/lib/better-stack | ||
| - beyla_supervisor_socket:/beyla_supervisor_socket |
There was a problem hiding this comment.
I would prefer to nest the socket under /var/lib/better-stack
Yes, good shout! I will probably even move the Dockerfiles into their respective spots.
Yes, coming tomorrow once I'm happy there aren't too many corner cases in the simple case of compose!
Yes, from this repository, I will be reintroducing them in Telemetry soonish 🙏
Reasonable! I'll make the adjustment. |
It's noisy, so here's the pertinent changes:
/var/lib/better-stackis mounted between the containers