Skip to content

Comments

Remotely-controlled collector#75

Merged
paweljw merged 31 commits intomainfrom
pawel/remote-loaded-collector
Nov 7, 2025
Merged

Remotely-controlled collector#75
paweljw merged 31 commits intomainfrom
pawel/remote-loaded-collector

Conversation

@paweljw
Copy link
Member

@paweljw paweljw commented Nov 5, 2025

It's noisy, so here's the pertinent changes:

  • images contain almost nothing besides an empty initial supervisord.conf and (for collector) the bootstrap script
  • bootstrap.sh runs once, and if successful - updater takes over
  • even vector healthcheck is remote
  • host path /var/lib/better-stack is mounted between the containers
  • directly controlling supervisord in the beyla container via a socket (exposed in volume)
  • direct supervisor run replaced with scripts that can install the initial supervisord.conf if needed

@paweljw paweljw requested a review from curusarn November 5, 2025 15:33
@curusarn
Copy link
Contributor

curusarn commented Nov 5, 2025

Thanks @paweljw!

💄: Could you nest the files for Dockerfile under e.g. collector/ directory for consistency with beyla/ and Dockerfile.beyla? Currently, there seems to be a lot of subtle differences in paths between the two images.

@curusarn
Copy link
Contributor

curusarn commented Nov 5, 2025

Any changes needed to Kubernetes configs? E.g. https://github.com/BetterStackHQ/collector-helm-chart/blob/main/templates/daemonset.yaml#L146

Copy link
Contributor

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, looks good 👍

- letsencrypt:/etc/letsencrypt
- ssl-certs:/etc/ssl
- /var/lib/better-stack:/var/lib/better-stack
- beyla_supervisor_socket:/beyla_supervisor_socket
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to nest the socket under /var/lib/better-stack

@paweljw
Copy link
Member Author

paweljw commented Nov 5, 2025

@curusarn

Could you nest the files for Dockerfile under e.g. collector/ directory

Yes, good shout! I will probably even move the Dockerfiles into their respective spots.

Any changes needed to Kubernetes configs?

Yes, coming tomorrow once I'm happy there aren't too many corner cases in the simple case of compose!

Are we intentionally loosing all tests?

Yes, from this repository, I will be reintroducing them in Telemetry soonish 🙏

I would prefer to nest the socket under /var/lib/better-stack

Reasonable! I'll make the adjustment.

@paweljw paweljw merged commit 2544f48 into main Nov 7, 2025
3 checks passed
@paweljw paweljw deleted the pawel/remote-loaded-collector branch November 7, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants