Skip to content

initial idea pingpong interpolation alternative #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

initial idea pingpong interpolation alternative #2814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/custom-snippets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@ export type CustomREPLCommandSnippet = {
snippet: string;
repl?: string;
ns?: string;
evaluationSendCodeToOutputWindow?: boolean;
pingPong?: boolean;
};

type SnippetDefinition = {
snippet: string;
ns: string;
repl: string;
evaluationSendCodeToOutputWindow?: boolean;
pingPong?: boolean;
};

export function evaluateCustomCodeSnippetCommand(codeOrKeyOrSnippet?: string | SnippetDefinition) {
Expand Down Expand Up @@ -74,7 +77,12 @@ async function evaluateCodeOrKeyOrSnippet(codeOrKeyOrSnippet?: string | SnippetD
nsForm,
snippetDefinition.repl
);
await evaluateCodeInContext(editor, snippetDefinition.snippet, context, options);
const result = await evaluateCodeInContext(editor, snippetDefinition.snippet, context, options);

if (snippetDefinition.pingPong) {
console.log('pingPong', result);
await evaluateCodeInContext(editor, result, context, options);
}
}

async function evaluateCodeInContext(
Expand Down Expand Up @@ -119,6 +127,8 @@ async function getSnippetDefinition(codeOrKey: string, editorNS: string, editorR
description: `${entry.repl}`,
repl: `${entry.repl}`,
snippet: entry.snippet,
pingPong: entry.pingPong,
evaluationSendCodeToOutputWindow: entry.evaluationSendCodeToOutputWindow,
};
snippetsMenuItems.push(item);
if (!snippetsDict[entry.key]) {
Expand Down
3 changes: 3 additions & 0 deletions src/evaluate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ async function evaluateCodeUpdatingUI(
await session.evaluateInNs(options.nsForm, outputWindow.getNs());
}

console.log('evaluateCodeUpdatingUI CODE', code);

const context: NReplEvaluation = session.eval(code, ns, {
file: filePath,
line: line + 1,
Expand All @@ -139,6 +141,7 @@ async function evaluateCodeUpdatingUI(
value = util.stripAnsi(context.pprintOut || value);

result = value;
console.log('evaluateCodeUpdatingUI RESULT', result);

flareHandler.inspect(value, (code) => evaluateCodeUpdatingUI(code, options, selection));

Expand Down