Fix zoomToElement in case of nested TransformWrapper #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
zoomToElementfunction inTransformWrapperincorrectly calculates the target position when a parentTransformWrapperhas azoomvalue different from1.Before the Fix
When calling
zoomToElementon a childTransformWrapperwith a parent that haszoom !== 1, the element would not be centered or zoomed correctly.After the Fix
The
zoomToElementfunction now correctly accounts for parent transformations, ensuring the target element is properly centered and zoomed regardless of the parent zoom state.How to Test
TransformWrappercomponents.zoomvalue different from1on a parentTransformWrapper.zoomToElementon a childTransformWrapper.