chore: Refactor operation classes to functions #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzane
force-pushed
the
rzane/refactor
branch
3 times, most recently
from
52f3263 to
3391ad4
Compare
- Convert Identifier class to saveIdentifier function - Update visitor.ts to use function instead of class - Update tests to use function directly - Export IdentifierOptions type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Convert ABConfiguration class to getABVariants function with internal helper functions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
samandmoore
approved these changes
Jan 7, 2026
Member
samandmoore
left a comment
samandmoore
left a comment
There was a problem hiding this comment.
domainlgtm
we will have to tweak the browser extension based on a few of these changes, but that's no big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm looking to make the code a little bit simpler. These are patterns that I'm looking to remove here:
VisitorandAssignment. These are both mutable objects and are exposed via the public API.This PR does not change the public API.
Please review this PR with "hide whitespace" enabled, since that's the majority of the diff in test files.
/no-platform