Remove Her dependency

Gemfile.lock

@@ -1,13 +1,11 @@
 PATH
   remote: .
   specs:
-    test_track_rails_client (8.0.0)
+    test_track_rails_client (9.0.0)
       activejob (>= 7.0, < 8.1)
       activemodel (>= 7.0, < 8.1)
-      faraday (>= 0.8)
-      faraday_middleware
+      faraday (~> 1.10)
       mixpanel-ruby (~> 1.4)
-      multi_json (~> 1.7)
       public_suffix (>= 2.0.0)
       railties (>= 7.0, < 8.1)
       request_store (~> 1.3)
@@ -103,8 +101,6 @@ GEM
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    faraday_middleware (1.2.1)
-      faraday (~> 1.0)
     globalid (1.2.1)
       activesupport (>= 6.1)
     hashdiff (1.1.2)
@@ -127,7 +123,6 @@ GEM
     method_source (1.1.0)
     minitest (5.25.4)
     mixpanel-ruby (1.7.0)
-    multi_json (1.15.0)
     multipart-post (2.4.1)
     nokogiri (1.18.2-arm64-darwin)
       racc (~> 1.4)

app/models/concerns/test_track/persistence.rb

@@ -0,0 +1,29 @@
+module TestTrack::Persistence
+  extend ActiveSupport::Concern
+
+  module ClassMethods
+    def create!(attributes)
+      new(attributes).tap(&:save!)
+    end
+  end
+
+  def save
+    return false unless valid?
+
+    persist!
+    true
+  rescue Faraday::UnprocessableEntityError
+    errors.add(:base, 'The HTTP request failed with a 422 status code')
+    false
+  end
+
+  def save!
+    save or raise(ActiveModel::ValidationError, self)
+  end
+
+  private
+
+  def persist!
+    raise NotImplementedError
+  end
+end

app/models/concerns/test_track/resource.rb

@@ -0,0 +1,14 @@
+module TestTrack::Resource
+  extend ActiveSupport::Concern
+
+  include ActiveModel::Model
+  include ActiveModel::Attributes
+
+  private
+
+  def _assign_attribute(name, value)
+    super
+  rescue ActiveModel::UnknownAttributeError
+    # Don't raise when we encounter an unknown attribute.
+  end
+end

app/models/test_track/remote/assignment.rb

@@ -1,10 +1,19 @@
 class TestTrack::Remote::Assignment
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
+  include ActiveModel::Dirty
 
-  attributes :split_name, :variant, :context, :unsynced
+  attribute :split_name
+  attribute :variant
+  attribute :context
+  attribute :unsynced, :boolean
 
   validates :split_name, :variant, :mixpanel_result, presence: true
 
+  def initialize(...)
+    super
+    clear_changes_information
+  end
+
   def unsynced?
     unsynced || variant_changed?
   end

app/models/test_track/remote/assignment_detail.rb

@@ -1,16 +1,11 @@
 class TestTrack::Remote::AssignmentDetail
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
 
-  attributes :split_location, :split_name, :variant_name, :variant_description, :assigned_at
-
-  def assigned_at
-    original = super
-    if original.blank? || !original.respond_to?(:in_time_zone)
-      nil
-    else
-      original.in_time_zone rescue nil # rubocop:disable Style/RescueModifier
-    end
-  end
+  attribute :split_location
+  attribute :split_name
+  attribute :variant_name
+  attribute :variant_description
+  attribute :assigned_at, :datetime
 
   def self.fake_instance_attributes(_)
     {

app/models/test_track/remote/assignment_event.rb

@@ -1,15 +1,25 @@
 class TestTrack::Remote::AssignmentEvent
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
+  include TestTrack::Persistence
 
-  collection_path 'api/v1/assignment_event'
-
-  attributes :visitor_id, :split_name, :unsynced
+  attribute :visitor_id
+  attribute :split_name
+  attribute :mixpanel_result
+  attribute :context
+  attribute :unsynced, :boolean
 
   validates :visitor_id, :split_name, :mixpanel_result, presence: true
 
   alias unsynced? unsynced
 
-  def fake_save_response_attributes
-    nil # :no_content is the expected response type
+  private
+
+  def persist!
+    TestTrack::Client.request(
+      method: :post,
+      path: 'api/v1/assignment_event',
+      body: { context:, visitor_id:, split_name:, mixpanel_result: },
+      fake: nil
+    )
   end
 end

app/models/test_track/remote/fake_server.rb

@@ -1,9 +1,7 @@
 class TestTrack::Remote::FakeServer
-  include TestTrack::RemoteModel
-
   def self.reset!(seed)
     raise('Cannot reset FakeServer if TestTrack is enabled.') if TestTrack.enabled?
 
-    put('api/v1/reset', seed:)
+    TestTrack::Client.connection.put('api/v1/reset', seed:)
   end
 end

app/models/test_track/remote/identifier.rb

@@ -1,27 +1,31 @@
 class TestTrack::Remote::Identifier
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
+  include TestTrack::Persistence
 
-  collection_path 'api/v1/identifier'
-
-  has_one :remote_visitor, data_key: :visitor, class_name: "TestTrack::Remote::Visitor"
-
-  attributes :identifier_type, :visitor_id, :value
+  attribute :identifier_type
+  attribute :visitor_id
+  attribute :value
 
   validates :identifier_type, :visitor_id, :value, presence: true
 
-  def fake_save_response_attributes
-    { visitor: { id: visitor_id, assignments: [] } }
+  def visitor
+    @visitor or raise('Visitor data unavailable until you save this identifier.')
   end
 
-  def visitor
-    @visitor ||= TestTrack::Visitor.new(visitor_opts!)
+  def visitor=(visitor_attributes)
+    @visitor = TestTrack::Remote::Visitor.new(visitor_attributes).to_visitor
   end
 
   private
 
-  def visitor_opts!
-    raise("Visitor data unavailable until you save this identifier.") unless attributes[:remote_visitor]
+  def persist!
+    result = TestTrack::Client.request(
+      method: :post,
+      path: 'api/v1/identifier',
+      body: { identifier_type:, visitor_id:, value: },
+      fake: { visitor: { id: visitor_id, assignments: [] } }
+    )
 
-    { id: remote_visitor.id, assignments: remote_visitor.assignments }
+    assign_attributes(result)
   end
 end

app/models/test_track/remote/identifier_type.rb

@@ -1,13 +1,19 @@
 class TestTrack::Remote::IdentifierType
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
+  include TestTrack::Persistence
 
-  collection_path 'api/v1/identifier_type'
-
-  attributes :name
+  attribute :name
 
   validates :name, presence: true
 
-  def fake_save_response_attributes
-    nil # :no_content is the expected response type
+  private
+
+  def persist!
+    TestTrack::Client.request(
+      method: :post,
+      path: 'api/v1/identifier_type',
+      body: { name: },
+      fake: nil
+    )
   end
 end

app/models/test_track/remote/split_config.rb

@@ -1,13 +1,30 @@
 class TestTrack::Remote::SplitConfig
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
+  include TestTrack::Persistence
 
-  collection_path 'api/v1/split_configs'
-
-  attributes :name, :weighting_registry
+  attribute :name
+  attribute :weighting_registry
 
   validates :name, :weighting_registry, presence: true
 
-  def fake_save_response_attributes
-    nil # :no_content is the expected response type
+  def self.destroy_existing(id)
+    TestTrack::Client.request(
+      method: :delete,
+      path: "api/v1/split_configs/#{id}",
+      fake: nil
+    )
+
+    nil
+  end
+
+  private
+
+  def persist!
+    TestTrack::Client.request(
+      method: :post,
+      path: 'api/v1/split_configs',
+      body: { name:, weighting_registry: },
+      fake: nil
+    )
   end
 end

app/models/test_track/remote/split_detail.rb

@@ -1,17 +1,23 @@
 class TestTrack::Remote::SplitDetail
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
 
-  collection_path 'api/v1/split_details'
-
-  attributes :name, :hypothesis, :assignment_criteria, :description, :owner, :location, :platform, :variant_details
+  attribute :name
+  attribute :hypothesis
+  attribute :assignment_criteria
+  attribute :description
+  attribute :owner
+  attribute :location
+  attribute :platform
+  attribute :variant_details
 
   def self.from_name(name)
-    # TODO: FakeableHer needs to make this faking a feature of `get`
-    if faked?
-      new(fake_instance_attributes(name))
-    else
-      get("api/v1/split_details/#{name}")
-    end
+    result = TestTrack::Client.request(
+      method: :get,
+      path: "api/v1/split_details/#{name}",
+      fake: fake_instance_attributes(name)
+    )
+
+    new(result)
   end
 
   def self.fake_instance_attributes(name)
@@ -39,4 +45,8 @@ def self.fake_variant_details
       }
     ]
   end
+
+  def variant_details=(values)
+    super(values.map(&:symbolize_keys))
+  end
 end

app/models/test_track/remote/split_registry.rb

@@ -1,30 +1,32 @@
 class TestTrack::Remote::SplitRegistry
-  include TestTrack::RemoteModel
+  include TestTrack::Resource
 
   CACHE_KEY = 'test_track_split_registry'.freeze
 
-  collection_path 'api/v3/builds/:build_timestamp/split_registry'
+  attribute :splits
+  attribute :experience_sampling_weight
 
   class << self
     def fake_instance_attributes(_)
       ::TestTrack::Fake::SplitRegistry.instance.to_h
     end
 
     def instance
-      # TODO: FakeableHer needs to make this faking a feature of `get`
-      if faked?
-        new(fake_instance_attributes(nil))
-      else
-        get("api/v3/builds/#{TestTrack.build_timestamp}/split_registry")
-      end
+      result = TestTrack::Client.request(
+        method: :get,
+        path: "api/v3/builds/#{TestTrack.build_timestamp}/split_registry",
+        fake: fake_instance_attributes(nil)
+      )
+
+      new(result)
     end
 
     def reset
       Rails.cache.delete(CACHE_KEY)
     end
 
     def to_hash
-      if faked?
+      if TestTrack::Client.fake?
         instance.attributes.freeze
       else
         fetch_cache { instance.attributes }.freeze