Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…napari-clusters-plotter into fix-cluster-memorization
for more information, see https://pre-commit.ci
…napari-clusters-plotter into fix-cluster-memorization
for more information, see https://pre-commit.ci
This reverts commit 1a792f4.
jo-mueller
force-pushed
the
fix-cluster-memorization
branch
from
acfe4ac to
27e5bc3
Compare
jo-mueller
force-pushed
the
fix-cluster-memorization
branch
from
27e5bc3 to
aaf8f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
notebooks/demo_new_plotter.ipynbandsrc/napari_clusters_plotterfiles, focusing on improving the plotter functionality and adding new tests. The most important changes include modifications to handle theMANUAL_CLUSTER_IDfeature, updates to data handling in the plotter widget, and new test cases for cluster memorization.Improvements to plotter functionality:
notebooks/demo_new_plotter.ipynb: Adjusted the data generation process to exclude the last frame forpoints2and updated the features accordingly. Added code cells to display the features and their shapes. [1] [2] [3]src/napari_clusters_plotter/_algorithm_widget.py: Modified thecommon_columnsmethod to excludeMANUAL_CLUSTER_IDfrom being used as a feature.src/napari_clusters_plotter/_new_plotter_widget.py: Updated the_replotmethod to handleMANUAL_CLUSTER_IDand removed the_get_datamethod. Added code to store cluster indices in the features table in_color_layer_by_cluster_id. [1] [2] [3]New test cases:
src/napari_clusters_plotter/_tests/test_plotter.py: Added a new helper functioncreate_multi_point_layerand a test casetest_cluster_memorizationto verify that cluster selections are correctly memorized and restored. [1] [2]