Merged
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383
This re-enables the histogram functionality from the old clusters-plotter for the upcoming 0.9.0.
Long description
This pull request introduces enhancements to the
napari_clusters_plotterplugin, focusing on adding support for 2D histograms, improving colormap handling, and refining the overall plotting functionality. It also includes updates to dependencies and new tests to ensure the robustness of the changes.Feature Enhancements:
HISTOGRAM2Dand updating thePlottingTypeenum and related UI elements (_setup_ui,_on_plot_type_changed). [1] [2] [3]colormap_referencedictionary to centralize colormap selection logic based on plot type and data categorization, simplifying the_replotmethod. [1] [2]Dependency Updates:
biaplotterdependency version from>=0.1.0to>=0.2.0inpyproject.toml.Code Simplifications:
_color_layer_by_valueby replacing multiple calls with a singlecolor_indices_to_rgbamethod.ArtistType) and refactored active artist initialization to use string identifiers instead of enum members. [1] [2]Testing Improvements:
test_histogram_supportto validate the functionality of the newHISTOGRAM2Dplot type with various layer types.UI Updates:
plot_type_boxdropdown in the UI to allow users to switch between plot types dynamically.