Merged
Conversation
…l to bibigrid_test.yaml
jkrue
approved these changes
Jun 17, 2025
jkrue
added a commit
that referenced
this pull request
Sep 24, 2025
* Fix rest parallel (#652) * added write to remote * first attempt at remote writing * changed instances of write_yaml that happen for creation to direct remote writes. * added TODO * changed os_versions in cloud_node_requirements.yaml * changed version number. Went down to 3 to align with github repository * fixed global variable not static causing parallel create runs to affect each other * pleasing linter * pleasing linter * Fixing node memory handling (#655) * Attempt using TRES_CORE_MEMORY * instead of //32 and capped at 2000 //4 +1000 sounds more reasonable * fixed equation * log warning if ram < 4096 * added unit * line too long * Address volumes by id not name internally (#656) * fixed volume name or id * added new volume key "id" to schema * added new volume key "id" to rest model * moved rest models to models/ folder * fixed tests, improved function naming * improved readability. Ignored pylint multiple branches for volume creation * duplicate ignore * added disable duplicate code * removed code duplicate * fixed name not set bug, renamed path of ingetration_test bibigrid.yaml to bibigrid_test.yaml * added info in configuration.md * updated bibigrid.yaml * Draft a POC for SOCKS support * improve socks connection retry logic * Add documentation for using socks5Proxy * remove support of focal repositories * add handler for apt cache update * tpyo, flush handlers * added newline * Restructure package to allow building with uv/pip etc (#660) * Add build system - use uv for dependency management - add bibigrid entrypoint - use click for command line parsing * Adapt pyproject.toml * adapy pyproject.toml * Restructure package - add pyproject.toml and use uv as build system - move ansible resources into package and adapt paths * remove auto-generated files * remove auto-generated file again * updated resources paths to bibigrid/resources * Updated CLI click. Changed to match structure and argument * dirty fix * minor updates to usability and documentation * fixed path for integration_test * fixed startup to new run_action structure * pleased pylint * updated documentation from 'bibigrid -c' to 'bibigrid create' * rebuild uv.lock * updated version in pyproject.toml to match version change to align with future bibigrid releases * changed cli to main to be more explicit * added a single line to explain how to install BiBiGrid as a package. Can be improved upon in the future. --------- Co-authored-by: Xaver Stiensmeier <xaverstiensmeier@gmx.de> * changed dependency installation for linting workflow due to pytoml instead of requirements files * fixing ansible lint not being installed * fixed path for linter * disabled pylint too many arguments for cli * implemented/adapted paramiko sock5 connection * ide now supports socks5 * removed extra debug messages * fixed tests * minor readme fixes * added very basic documentation * added information on how to establish the connection * improved socks5 documentation * set mem to * 0.98 - 150 * please linter * fix default partition warning * force template overwrite * early state. Not working because it is unclear how we want to dynamically load file path * fix(Dockerfile):updated dockerfile to work with new pyproject.toml * Fix docker restarts even when no change (#673) * fix docker restarts even when no change * changed to better notify structure * fixed name of handler * Allow setting custom cluster_id when creating resources (#661) * Allow setting custom cluster_id * added log message for cluster id in startup * improved cluster_id checking and allowed passing cluster_id to create from CLI * improved error message for malformed cluster ids * improved error message for malformed cluster ids * updated uv.lock and re-added requirements files in case someone prefers them. * enabled MAX_ID_LENGTH check again. * improved log message --------- Co-authored-by: Xaver Stiensmeier <xaverstiensmeier@gmx.de> * fix(Locks):waiting for all locks to avoid held locks * updated packages * pleased ansible lint by adding bibigrid_ to runtime defined variables * fixing line too long * Fixed paramiko version * pleased linter --------- Co-authored-by: Manuel Koesters <17874544+MKoesters@users.noreply.github.com> Co-authored-by: Jan Krueger <jkrueger@cebitec.uni-bielefeld.de> Co-authored-by: Manuel <mkoes@protonmail.com> Co-authored-by: dweinholz <david-weinholz@web.de>
jkrue
added a commit
that referenced
this pull request
Oct 8, 2025
* Fix rest parallel (#652) * added write to remote * first attempt at remote writing * changed instances of write_yaml that happen for creation to direct remote writes. * added TODO * changed os_versions in cloud_node_requirements.yaml * changed version number. Went down to 3 to align with github repository * fixed global variable not static causing parallel create runs to affect each other * pleasing linter * pleasing linter * Fixing node memory handling (#655) * Attempt using TRES_CORE_MEMORY * instead of //32 and capped at 2000 //4 +1000 sounds more reasonable * fixed equation * log warning if ram < 4096 * added unit * line too long * Address volumes by id not name internally (#656) * fixed volume name or id * added new volume key "id" to schema * added new volume key "id" to rest model * moved rest models to models/ folder * fixed tests, improved function naming * improved readability. Ignored pylint multiple branches for volume creation * duplicate ignore * added disable duplicate code * removed code duplicate * fixed name not set bug, renamed path of ingetration_test bibigrid.yaml to bibigrid_test.yaml * added info in configuration.md * updated bibigrid.yaml * Draft a POC for SOCKS support * improve socks connection retry logic * Add documentation for using socks5Proxy * remove support of focal repositories * add handler for apt cache update * tpyo, flush handlers * added newline * Restructure package to allow building with uv/pip etc (#660) * Add build system - use uv for dependency management - add bibigrid entrypoint - use click for command line parsing * Adapt pyproject.toml * adapy pyproject.toml * Restructure package - add pyproject.toml and use uv as build system - move ansible resources into package and adapt paths * remove auto-generated files * remove auto-generated file again * updated resources paths to bibigrid/resources * Updated CLI click. Changed to match structure and argument * dirty fix * minor updates to usability and documentation * fixed path for integration_test * fixed startup to new run_action structure * pleased pylint * updated documentation from 'bibigrid -c' to 'bibigrid create' * rebuild uv.lock * updated version in pyproject.toml to match version change to align with future bibigrid releases * changed cli to main to be more explicit * added a single line to explain how to install BiBiGrid as a package. Can be improved upon in the future. --------- Co-authored-by: Xaver Stiensmeier <xaverstiensmeier@gmx.de> * changed dependency installation for linting workflow due to pytoml instead of requirements files * fixing ansible lint not being installed * fixed path for linter * disabled pylint too many arguments for cli * implemented/adapted paramiko sock5 connection * ide now supports socks5 * removed extra debug messages * fixed tests * minor readme fixes * added very basic documentation * added information on how to establish the connection * improved socks5 documentation * set mem to * 0.98 - 150 * please linter * fix default partition warning * force template overwrite * early state. Not working because it is unclear how we want to dynamically load file path * fix(Dockerfile):updated dockerfile to work with new pyproject.toml * Fix docker restarts even when no change (#673) * fix docker restarts even when no change * changed to better notify structure * fixed name of handler * Allow setting custom cluster_id when creating resources (#661) * Allow setting custom cluster_id * added log message for cluster id in startup * improved cluster_id checking and allowed passing cluster_id to create from CLI * improved error message for malformed cluster ids * improved error message for malformed cluster ids * updated uv.lock and re-added requirements files in case someone prefers them. * enabled MAX_ID_LENGTH check again. * improved log message --------- Co-authored-by: Xaver Stiensmeier <xaverstiensmeier@gmx.de> * fix(Locks):waiting for all locks to avoid held locks * updated packages * pleased ansible lint by adding bibigrid_ to runtime defined variables * fixing line too long * Fixed paramiko version * pleased linter * added zenodo link --------- Co-authored-by: Manuel Koesters <17874544+MKoesters@users.noreply.github.com> Co-authored-by: Jan Krueger <jkrueger@cebitec.uni-bielefeld.de> Co-authored-by: Manuel <mkoes@protonmail.com> Co-authored-by: dweinholz <david-weinholz@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that users could create multiple volumes with the same name, it is safer for bibigrid to address existing volumes using ids instead of names. This update does exactly that. One can use the key id for existing volumes: