Add crowdin translation-upload (feedback) action#2999
Add crowdin translation-upload (feedback) action#2999ferdnyc wants to merge 2 commits intoBiglySoftware:masterfrom
Conversation
|
Oh, right: Because Github sensibly won't run newly-created actions from PRs, this will have to be merged before any testing can be done. So, I guess, once the secrets are created, it would probably make sense to merge this with the |
|
I added |
|
That failure looks transient, it died in the wiki tests on Windows for some reason. |
|
I'll force-push the branch so the CI restarts, see what that failure was all about. (Edit: As suspected, it was just random transient breakage.) |
Update 2
I'm beginning to suspect (though they never actually say it anywhere, that I can find) that the "Always import new translations..." option is an Enterprise-only feature. So, I take it back (again)... it probably is necessary to do things this way, after all.
Update
Turns out this may not be necessary at all, as there may be a simpler solution.According to Crowdin's docs, their GitHub integration should now have a checkbox for "Always import new translations from the repository". It's turned off by default, but turning it on might set all this up for us.
@parg, @TuxPaper, worth a look?
cc: @lislei
↑ (It's down here at the bottom)Original summary
This PR grew out of discussion in #973, regarding feeding translations back to Crowdin when they're updated locally. The code here is an attempt to make that work. It is untested, because it cannot be tested until some prerequisites are met.
This PR will not work and SHOULD NOT BE MERGED unless the repository is first configured with the necessary Crowdin credentials so that the action has access to upload into the Crowdin project.
Obtaining that access requires someone with admin access to both the Crowdin and Github sides of the project to do the following:
CROWDIN_PROJECT_IDshould store the project IDCROWDIN_PERSONAL_TOKENshould store the generated tokenOnly after that is done, will it be possible to TEST this PR. Because it currently contains the setting
dryrun_action: true, it still won't do anything that would affect the Crowdin project.If things look sane, then we can remove that line and test it for real.
cc: @parg @TuxPaper