Skip to content

Conversation

@jordan-hemming
Copy link
Contributor

I noticed that the mouse wheel wasn't working at all in the windows console build. It seems that a change was added to check for mouse wheel support, but it looks like a typo to me.

This PR corrects the typo and restores mouse wheel functionality.

…ed HOUSE_WHEELED and HOUSE_HWHEELED to MOUSE_WHEELED and MOUSE_HWHEELED.
@Bill-Gray Bill-Gray merged commit 94c4b4b into Bill-Gray:master Sep 26, 2025
1 check was pending
@Bill-Gray
Copy link
Owner

Well, that was unusually stupid of me... though on the bright side, more easily fixed than some stupid things I've done. Thanks for the fix!

@rhaberkorn
Copy link
Contributor

@GitMensch @Bill-Gray Any chance to get this fix into MSYS soon?

@GitMensch
Copy link
Collaborator

GitMensch commented Jan 7, 2026

@Bill-Gray's point in the past was that a release is mostly done upon request - and with the 69 commits since the last one I think that would be fine. If he does the HISTORY.md and date change and do the release in the next days I'd be able to get it to MSYS2 within 18 hours after that.

I'd really like to get #348 in before, if possible (waiting on response from Bill who could pull it in himself if the additional Makefile changes are fine/done).

@rhaberkorn
Copy link
Contributor

If he does the HISTORY.md and date change and do the release in the next days I'd be able to get it to MSYS2 within 18 hours after that.

Perhaps I should just install a freshly built PDCursesMod into my CI containers, so I will no longer depend on MSYS releases.

@Bill-Gray
Copy link
Owner

Perhaps I should just install a freshly built PDCursesMod into my CI containers, so I will no longer depend on MSYS releases.

That'd work. But it does seem a fair number of people rely on the release versions anyway, so I'm not off the hook for those.

So I'll do the HISTORY.md and version constant updates... probably today, certainly soon.

@Bill-Gray
Copy link
Owner

Updated HISTORY.md and version date (but not, quite yet, PDC_VERSION_CHANGE; I think we're close to figuring out issue #348, and there's a decent chance we could fix that as part of this update.)

@rhaberkorn
Copy link
Contributor

@GitMensch Let me know once you release v4.5.4 into MSYS.

Don't be irritated by the new tickets I opened. For all of them I have workarounds. I just usually do not care to report bugs/incompatibilities for which I have an obvious workaround. But from now on I guess it will benefit the project to report each and every one.

@Bill-Gray
Copy link
Owner

Don't be irritated by the new tickets I opened.

No worries. I may not do all that well at keeping up with them. But I'd rather know about them than not know about them.

@GitMensch
Copy link
Collaborator

GitMensch commented Jan 8, 2026

Package built for MSYS2 in CI - so you can download the package from the CI artifacts already and install it with pacman (or wait until it is included and the nightly build provides the package for a direct update):

msys2/MINGW-packages#27254

... and now also in MSYS2 via pacman,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants