Skip to content

Comments

client_manager test function#156

Open
sl5035 wants to merge 3 commits intoBillingegroup:clientfrom
sl5035:client_manager_test
Open

client_manager test function#156
sl5035 wants to merge 3 commits intoBillingegroup:clientfrom
sl5035:client_manager_test

Conversation

@sl5035
Copy link

@sl5035 sl5035 commented Mar 8, 2023

No description provided.

@sbillinge
Copy link
Collaborator

Hi @sl5035 I changed the CI, added codecov and moved from circleci to GH actions. Please can you update your local client branch, and then merge it into this branch so the PR is using the new CI? THnaks so much.

@sbillinge
Copy link
Collaborator

btw, I removed ruamel.yaml dependency. I think it is better to just have one yaml dependency. It probably means that fsclient and/or mongoclient is broken but can be fixed by changing the yaml calls to use pyyaml. If there is functionality in ruamel.yml that you need, maybe we can change the dependency so it is used everywhere and again we just have one yaml dependency.

@sl5035
Copy link
Author

sl5035 commented Mar 19, 2023

Hi @sl5035 I changed the CI, added codecov and moved from circleci to GH actions. Please can you update your local client branch, and then merge it into this branch so the PR is using the new CI? THnaks so much.

Done!

btw, I removed ruamel.yaml dependency. I think it is better to just have one yaml dependency. It probably means that fsclient and/or mongoclient is broken but can be fixed by changing the yaml calls to use pyyaml. If there is functionality in ruamel.yml that you need, maybe we can change the dependency so it is used everywhere and again we just have one yaml dependency.

Ah, got it. Then I'll be working on fsclient to fix yaml dependencies first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants