Open
Conversation
Collaborator
Author
|
My bad on the mpl stylesheets. Commenting out now. |
Collaborator
Author
|
If I put the npy into json as well, I get a 3x slowdown |
Collaborator
|
Wow, great news. Asynch?
…On Thu, Aug 12, 2021, 3:05 PM zthatch ***@***.***> wrote:
Not sure how, but pydantic actually sped this up a LOT. Down from 30%
runtime to 1% runtime
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUPPACC7CKTCG2KHDFDT4QLNZANCNFSM5B4RYKNQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Collaborator
Author
|
Sorry, had to go back and edit this. The speed up was from something else
in a big PR. I opened another PR with just that change so that it could
easily be merged.
But we could try it asynch… good thought.
I wanted to eventually do mongodb access asynchly. So this would be a baby
step.
…-Zach
On Thu, Aug 12, 2021 at 4:36 PM Simon Billinge ***@***.***>
wrote:
Wow, great news. Asynch?
On Thu, Aug 12, 2021, 3:05 PM zthatch ***@***.***> wrote:
> Not sure how, but pydantic actually sped this up a LOT. Down from 30%
> runtime to 1% runtime
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#69 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABAOWUPPACC7CKTCG2KHDFDT4QLNZANCNFSM5B4RYKNQ
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJYSB6EPLR7TYMJFZ2EJ23TT4QWFDANCNFSM5B4RYKNQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran this with the profiler and actually didn't get any speed up on reads. This is only for 20, so I am not sure yet if it is worth it.