Conversation
…rency, realized that gcs doesn't support async concurrency
…elete this commit if google fixes their async block for gcs requests
Collaborator
Author
|
I asked the question on stackoverflow: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've threaded the google cloud storage requests such that they actually happen in parallel (google cloud python API does not yet support async parallelism). I've also restricted the thread spawning with a semaphore lock, which I've tested simply by testing how much slower it runs when you set the semaphore lock to size 1.
I have not tested that the lock successfully prevents stack overflow (there is a chance that the previous generator results are not relinquished when iterating through them as futures).