feat(api): return group_id in contact group create response#311
Open
Aliexe-code wants to merge 1 commit intoBillionmail:devfrom
Open
feat(api): return group_id in contact group create response#311Aliexe-code wants to merge 1 commit intoBillionmail:devfrom
Aliexe-code wants to merge 1 commit intoBillionmail:devfrom
Conversation
- Add group_id to CreateGroupRes data field - Return group_id for all creation types (1, 2, 3) - Fixes Billionmail#280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
Purpose
The
/api/contact/group/createendpoint currently returns success without the created group ID. Users need to query the group list to get the ID, which is inconvenient for automation and API integrations.Implementation
Datastruct withgroup_idfield toCreateGroupResresponse typeres.Data.GroupIdfor all 3 creation types (1, 2, 3) in the controllerTesting
go build ./api/contact/v1/... ./internal/controller/contact/...)API Response Example
Before:
{
"code": 0,
"message": "Group created successfully",
"data": null
}
After:
{
code: 0,
message: Group created successfully,
data: {
group_id: 123
}
}