-
Notifications
You must be signed in to change notification settings - Fork 2
feat(frontend): add discard changes button on edit wheel screen bb-467 #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iqbalalayubbi
wants to merge
126
commits into
main
Choose a base branch
from
467-feat-add-discard-changes-button-on-edit-wheel-screen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 124 commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
a6a4d4a
feat: slicing form design ui bb-9
iqbalalayubbi 6789363
Merge branch '9-feat-sign-up' into fix-lint
iqbalalayubbi 1a07082
fix: remove lint css root folder bb-0
iqbalalayubbi 0d9786c
feat: make toggle visibility password bb-9
iqbalalayubbi 91c4a09
feat: add user data in redux store bb-9
iqbalalayubbi eef6fb3
feat: make validation confirm password bb-9
iqbalalayubbi 4f1c228
fix: refactor unused code and comment bb-9
iqbalalayubbi 5fc8a04
style: adjust css variabel to match with other bb-9
iqbalalayubbi fcffd3e
refactor: make other props instead className bb-9
iqbalalayubbi f6aaac0
style: adjust css variabel conflict bb-9
iqbalalayubbi 5842e98
Merge branch 'main' into 9-feat-sign-up
iqbalalayubbi 8c9ae6e
Merge branch 'main' into 9-feat-sign-up
iqbalalayubbi 18bc6f6
Merge branch 'main' into 9-feat-sign-up
iqbalalayubbi d97f37c
chore: release-1.6.0 (#95)
github-actions[bot] dc53cac
fix: handle conflict with main branch bb-9
iqbalalayubbi 2e7c7b7
fix: update version in package.json bb-9
iqbalalayubbi a1bfc0e
refactor: using getValidClassNames and seperate each style in compone…
iqbalalayubbi 979b4e6
fix: handle conflict in app.tsx bb-9
iqbalalayubbi 24512fe
Merge branch 'main' into 9-feat-sign-up
iqbalalayubbi 3451234
style: change all changelog file bb-9
iqbalalayubbi ef12676
refactor: remove unused img and code bb-9
iqbalalayubbi e985ddc
style: change folder structure and handle typo name in class bb-9
iqbalalayubbi ba27cbc
fix: update package.json bb-9
iqbalalayubbi 78a277c
fix: update with main branch bb-9
iqbalalayubbi 21a4f00
fix: solve UI issue in sign up UI bb-9
iqbalalayubbi 0967b82
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi e290950
feat: redirect user to root after sign up bb-9
iqbalalayubbi 37dc177
feat: navigate user to root path bb-9
iqbalalayubbi 078b9c9
refactor: remove use navigate in sign up form bb-9
iqbalalayubbi 69db1ae
fix: solve conflict with main branch bb-9
iqbalalayubbi 584b46e
feat: add error handling sign up bb-9
iqbalalayubbi cc7a1cb
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 37f852b
fix: up to date package-lock with main bb-9
iqbalalayubbi 350f6ec
feat: remove try catch block bb-9
iqbalalayubbi 1120e37
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 3bb2bcb
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 8d12c26
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 4913cbf
feat: follow rules and messages from doc validation bb-209
iqbalalayubbi e45870e
feat: disabled button when schema invalid bb-209
iqbalalayubbi ecd974b
feat: add mode onchange in react hook form bb-209
iqbalalayubbi 9837a6a
refactor: remove unused user validation schema bb-209
iqbalalayubbi bce3fdf
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 774e5a1
refactor: remove unused validation & seperate const for user bb-209
iqbalalayubbi 60ba455
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 9981e2f
fix: remove confirm input in schema validation bb-209
iqbalalayubbi f8fa8b1
fix: solve conflict validation schema, rule, and regex form fe bb-209
iqbalalayubbi 6eade86
refactor: remove duplicate message for confirm input bb-209
iqbalalayubbi 8283027
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi f2abc4e
style: add type in variabel no error bb-209
iqbalalayubbi d133335
refactor: remove unused message in user validation bb-209
iqbalalayubbi 1d516a5
style: change email placeholder bb-209
iqbalalayubbi 7b4bfeb
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi f0ed650
style: change no error input const in user modules bb-209
iqbalalayubbi 9a1ac91
style: create constan folder in user module bb-209
iqbalalayubbi 8caaf63
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 17fa38d
fix: solved conflict validation regex rule bb-209
iqbalalayubbi 0c9ccdd
fix: show error popup auth & reorder password validation bb-209
iqbalalayubbi 920b748
chore: change package-lock.json bb-209
iqbalalayubbi 55c38cb
fix: change regex rule for email bb-209
iqbalalayubbi 26b42eb
fix: solve conflict package lock json bb-209
iqbalalayubbi 259c9b5
fix: change email rule validation bb-209
iqbalalayubbi 384f802
refactor: make notification as global for any page bb-209
iqbalalayubbi 2b6d65c
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi a2bdc10
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 9dcd2ee
feat: show logout confirmation bb-365
iqbalalayubbi de03868
refactor: wrap logout confirm popup using dialog tag bb-365
iqbalalayubbi e0841d6
fix: set false logout popup as default state bb-365
iqbalalayubbi 1d7d037
style: add class for img tag bb-365
iqbalalayubbi eb9d265
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi e87e177
style: change variabel popup into meaningful bb-365
iqbalalayubbi d0a5816
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi e220840
Merge branch 'main' into 365-feat-add-logout-confirmation
fshabanov dae6e9a
style: add variant for confirm button bb-365
iqbalalayubbi 02bb12d
fix: solve conflict with main branch bb-365
iqbalalayubbi 00f1ab6
Merge branch '365-feat-add-logout-confirmation' of https://github.com…
iqbalalayubbi 7b3fc5d
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi fcb082b
feat: add logo to sigin & signup pages bb-373
iqbalalayubbi 7daab72
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 9f957b6
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 72c3f7f
feat: update password functionality backend-frontend bb-417
iqbalalayubbi 278a2f2
feat: add success notification update password bb-417
iqbalalayubbi f32600a
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi bcd74bc
style: remove unused comment bb-417
iqbalalayubbi 5b6ea75
style: change response status swager spec bb-417
iqbalalayubbi 4a2b320
style: remove unused comment bb-417
iqbalalayubbi 2104a3f
refactor: remove token in update req & make helper check password bb-417
iqbalalayubbi 90dc845
fix: solve conflict main branch bb-417
iqbalalayubbi b1782dc
refactor: move check password to auth service and using API handler t…
iqbalalayubbi e2562b7
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 13f6a46
Merge branch 'main' into 417-feat-change-password-funcionality-in-pro…
fshabanov 1d9ba50
feat: add toggle eye button password bb-417
iqbalalayubbi ecfe48e
Merge branch '417-feat-change-password-funcionality-in-profile-screen…
iqbalalayubbi de8d9e5
Merge branch 'main' into 417-feat-change-password-funcionality-in-pro…
fshabanov 93a07d0
fix: solve not match confirm new password bb-417
iqbalalayubbi 867fcc6
Merge branch '417-feat-change-password-funcionality-in-profile-screen…
iqbalalayubbi 17135e8
fix: solve conflict main branch bb-417
iqbalalayubbi 83acb9a
refactor: remove fields object in confirm password custom validation …
iqbalalayubbi 185997c
refactor: remove fields object in confirm password custom validation …
iqbalalayubbi e9c7c5d
fix: solve conflict this branch bb-417
iqbalalayubbi 62eae78
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 3af9236
refactor: move confirm new password field to enum bb-417
iqbalalayubbi 1c2adb2
style: change enum property of confirm password custom validation bb-417
iqbalalayubbi 2c0804f
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi fdf4073
refactor: using get values instead watch in sign up mobile bb-417
iqbalalayubbi 8d420af
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 58ef8fb
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 97097b4
feat: add discard changes button on edit wheel screen bb-467
iqbalalayubbi 55bc3df
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 95a5ff6
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi cfc9074
refactor: change slider ref into prop value bb-467
iqbalalayubbi 2c79dd5
refactor: replace timing function with use effect bb-467
iqbalalayubbi a390ccd
refactor: remove areChangesDiscarded prop from slider component bb-467
iqbalalayubbi 990ba36
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 433fce2
refactor: using state hook to replace ref hook for scores data bb-467
iqbalalayubbi 74ed482
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi f9bae8e
refactor: call api to get original scores bb-467
iqbalalayubbi 65034ea
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 60010f6
Merge branch 'main' into 467-feat-add-discard-changes-button-on-edit-…
fshabanov 83b0ed6
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 8c1d9da
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 07f73c3
fix: discard button disabled when click and reset the scores when swi…
iqbalalayubbi 3fdb953
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi bc35260
Merge branch '467-feat-add-discard-changes-button-on-edit-wheel-scree…
iqbalalayubbi 9dd1593
style: add constant value for reset changes state bb-467
iqbalalayubbi 9fbf356
Merge branch 'main' of https://github.com/BinaryStudioAcademy/bsa-202…
iqbalalayubbi 586dd6a
style: replace json stringify with for of to compare two objects bb-467
iqbalalayubbi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 7 additions & 1 deletion
8
.../root/components/user-wheel/libs/components/scores-edit-modal/libs/constants/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
const IS_DISCARD_BUTTON_DISABLED_INITIAL_VALUE = true; | ||
const AFTER_DISCARD_CHANGES_DELAY = 100; | ||
const IS_RESET_CHANGES_SCORES_INITIAL_VALUE = false; | ||
|
||
export { IS_DISCARD_BUTTON_DISABLED_INITIAL_VALUE }; | ||
export { | ||
AFTER_DISCARD_CHANGES_DELAY, | ||
IS_DISCARD_BUTTON_DISABLED_INITIAL_VALUE, | ||
IS_RESET_CHANGES_SCORES_INITIAL_VALUE, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.