Conversation
Summary of ChangesHello @Nandaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature that provides granular control over the application of common styles within the ADetailer prompt. By adding an explicit option to enable or disable styles, users can prevent unwanted style inheritance, particularly beneficial for scenarios like batch processing where specific ADetailer operations might require a clean slate without global styles. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new option to enable or disable common styles for the ADetailer prompt, which is a useful feature, especially for batch processing. The implementation is straightforward, adding a checkbox in the UI, a corresponding argument, and logic to apply the styles conditionally.
I've found one minor issue regarding the handling of the new parameter in the image's infotext. Please see my comment for details. Otherwise, the changes look good.
| ad_model: str = "None" | ||
| ad_model_classes: str = "" | ||
| ad_tab_enable: bool = True | ||
| ad_tab_enable_styles: bool = True |
There was a problem hiding this comment.
The new ad_tab_enable_styles argument is not handled in the extra_params method. To keep the generated image's infotext clean, parameters with default values are usually not included. Please consider adding logic to the extra_params method to remove ADetailer tab enable styles from the output when it has its default value of True. This would be consistent with how other boolean flags and default-valued parameters are handled in this method.



Add option to enable/disable common styles for the adetailer prompt.
This is useful when performing batch and we don't want to include the common styles into specific adetailer prompt.