Skip to content

Implement OpenAPI 3.2.0 server name field with backward compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2025
Merged

Implement OpenAPI 3.2.0 server name field with backward compatibility #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc9758e
Initial plan
Copilot Sep 29, 2025
ef92cc1
Implement OpenAPI 3.2.0 server name field with backward compatibility
Copilot Sep 29, 2025
6485aa6
Apply suggestions from code review
baywet Sep 29, 2025
a60bb84
Update src/Microsoft.OpenApi/Models/OpenApiServer.cs
baywet Sep 29, 2025
c9fe497
chore: adds missing using
baywet Sep 29, 2025
1b54b85
Merge branch 'feat/oai-3-2-support' into copilot/fix-e82b7370-b029-4d…
kilifu Sep 29, 2025
d964404
chore: update EmptyModels benchmark results
Copilot Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...ark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
```

BenchmarkDotNet v0.15.4, Windows 11 (10.0.26200.6584)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
BenchmarkDotNet v0.15.4, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.414
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3

Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3

```
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
|------------- |---------------:|---------------:|-------------:|-----------:|-----------:|----------:|-------------:|
| PetStoreYaml | 979.3 μs | 375.3 μs | 20.57 μs | 62.5000 | 7.8125 | - | 387.37 KB |
| PetStoreJson | 508.5 μs | 427.5 μs | 23.43 μs | 39.0625 | 7.8125 | - | 249.51 KB |
| GHESYaml | 1,587,861.1 μs | 1,076,577.3 μs | 59,010.84 μs | 66000.0000 | 22000.0000 | 4000.0000 | 384511.51 KB |
| GHESJson | 599,442.5 μs | 843,317.6 μs | 46,225.08 μs | 40000.0000 | 16000.0000 | 3000.0000 | 245982.08 KB |
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
|------------- |---------------:|--------------:|------------:|-----------:|-----------:|----------:|-------------:|
| PetStoreYaml | 513.8 μs | 220.40 μs | 12.08 μs | 23.4375 | 3.9063 | - | 387.37 KB |
| PetStoreJson | 235.7 μs | 19.54 μs | 1.07 μs | 13.6719 | 1.9531 | - | 249.22 KB |
| GHESYaml | 1,008,778.7 μs | 50,002.60 μs | 2,740.81 μs | 26000.0000 | 20000.0000 | 3000.0000 | 384508.01 KB |
| GHESJson | 469,189.2 μs | 144,923.46 μs | 7,943.74 μs | 16000.0000 | 9000.0000 | 2000.0000 | 245977.2 KB |
8 changes: 4 additions & 4 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Method,Job,AnalyzeLaunchVariance,EvaluateOverhead,MaxAbsoluteError,MaxRelativeError,MinInvokeCount,MinIterationTime,OutlierMode,Affinity,EnvironmentVariables,Jit,LargeAddressAware,Platform,PowerPlanMode,Runtime,AllowVeryLargeObjects,Concurrent,CpuGroups,Force,HeapAffinitizeMask,HeapCount,NoAffinitize,RetainVm,Server,Arguments,BuildConfiguration,Clock,EngineFactory,NuGetReferences,Toolchain,IsMutator,InvocationCount,IterationCount,IterationTime,LaunchCount,MaxIterationCount,MaxWarmupIterationCount,MemoryRandomization,MinIterationCount,MinWarmupIterationCount,RunStrategy,UnrollFactor,WarmupCount,Mean,Error,StdDev,Gen0,Gen1,Gen2,Allocated
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,979.3 μs,375.3 μs,20.57 μs,62.5000,7.8125,0.0000,387.37 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,508.5 μs,427.5 μs,23.43 μs,39.0625,7.8125,0.0000,249.51 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,587,861.1 μs","1,076,577.3 μs","59,010.84 μs",66000.0000,22000.0000,4000.0000,384511.51 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"599,442.5 μs","843,317.6 μs","46,225.08 μs",40000.0000,16000.0000,3000.0000,245982.08 KB
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,513.8 μs,220.40 μs,12.08 μs,23.4375,3.9063,0.0000,387.37 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,235.7 μs,19.54 μs,1.07 μs,13.6719,1.9531,0.0000,249.22 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,008,778.7 μs","50,002.60 μs","2,740.81 μs",26000.0000,20000.0000,3000.0000,384508.01 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"469,189.2 μs","144,923.46 μs","7,943.74 μs",16000.0000,9000.0000,2000.0000,245977.2 KB
20 changes: 10 additions & 10 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang='en'>
<head>
<meta charset='utf-8' />
<title>performance.Descriptions-20250929-121242</title>
<title>performance.Descriptions-20250929-235233</title>

<style type="text/css">
table { border-collapse: collapse; display: block; width: 100%; overflow: auto; }
Expand All @@ -13,23 +13,23 @@
</head>
<body>
<pre><code>
BenchmarkDotNet v0.15.4, Windows 11 (10.0.26200.6584)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
BenchmarkDotNet v0.15.4, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.414
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3
</code></pre>
<pre><code>Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3
</code></pre>

<table>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
</tr>
</thead><tbody><tr><td>PetStoreYaml</td><td>979.3 &mu;s</td><td>375.3 &mu;s</td><td>20.57 &mu;s</td><td>62.5000</td><td>7.8125</td><td>-</td><td>387.37 KB</td>
</tr><tr><td>PetStoreJson</td><td>508.5 &mu;s</td><td>427.5 &mu;s</td><td>23.43 &mu;s</td><td>39.0625</td><td>7.8125</td><td>-</td><td>249.51 KB</td>
</tr><tr><td>GHESYaml</td><td>1,587,861.1 &mu;s</td><td>1,076,577.3 &mu;s</td><td>59,010.84 &mu;s</td><td>66000.0000</td><td>22000.0000</td><td>4000.0000</td><td>384511.51 KB</td>
</tr><tr><td>GHESJson</td><td>599,442.5 &mu;s</td><td>843,317.6 &mu;s</td><td>46,225.08 &mu;s</td><td>40000.0000</td><td>16000.0000</td><td>3000.0000</td><td>245982.08 KB</td>
</thead><tbody><tr><td>PetStoreYaml</td><td>513.8 &mu;s</td><td>220.40 &mu;s</td><td>12.08 &mu;s</td><td>23.4375</td><td>3.9063</td><td>-</td><td>387.37 KB</td>
</tr><tr><td>PetStoreJson</td><td>235.7 &mu;s</td><td>19.54 &mu;s</td><td>1.07 &mu;s</td><td>13.6719</td><td>1.9531</td><td>-</td><td>249.22 KB</td>
</tr><tr><td>GHESYaml</td><td>1,008,778.7 &mu;s</td><td>50,002.60 &mu;s</td><td>2,740.81 &mu;s</td><td>26000.0000</td><td>20000.0000</td><td>3000.0000</td><td>384508.01 KB</td>
</tr><tr><td>GHESJson</td><td>469,189.2 &mu;s</td><td>144,923.46 &mu;s</td><td>7,943.74 &mu;s</td><td>16000.0000</td><td>9000.0000</td><td>2000.0000</td><td>245977.2 KB</td>
</tr></tbody></table>
</body>
</html>
2 changes: 1 addition & 1 deletion performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json
View file
Open in desktop

Large diffs are not rendered by default.

68 changes: 34 additions & 34 deletions ...mark/BenchmarkDotNet.Artifacts/results/performance.EmptyModels-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
```

BenchmarkDotNet v0.15.4, Windows 11 (10.0.26200.6584)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
BenchmarkDotNet v0.15.4, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.414
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v4
[Host] : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.20 (8.0.20, 8.0.2025.41914), X64 RyuJIT x86-64-v3

Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3

```
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|---------------------------- |-----------:|-----------:|-----------:|-------:|----------:|
| EmptyApiCallback | 6.212 ns | 3.627 ns | 0.1988 ns | 0.0051 | 32 B |
| EmptyApiComponents | 6.707 ns | 2.423 ns | 0.1328 ns | 0.0166 | 104 B |
| EmptyApiContact | 6.376 ns | 10.314 ns | 0.5653 ns | 0.0076 | 48 B |
| EmptyApiDiscriminator | 6.735 ns | 3.089 ns | 0.1693 ns | 0.0064 | 40 B |
| EmptyDocument | 726.496 ns | 517.997 ns | 28.3932 ns | 0.1793 | 1136 B |
| EmptyApiEncoding | 6.933 ns | 25.121 ns | 1.3770 ns | 0.0089 | 56 B |
| EmptyApiExample | 10.714 ns | 24.903 ns | 1.3650 ns | 0.0089 | 56 B |
| EmptyApiExternalDocs | 6.494 ns | 5.991 ns | 0.3284 ns | 0.0064 | 40 B |
| EmptyApiHeader | 6.513 ns | 3.221 ns | 0.1766 ns | 0.0127 | 80 B |
| EmptyApiInfo | 9.555 ns | 6.141 ns | 0.3366 ns | 0.0127 | 80 B |
| EmptyApiLicense | 6.116 ns | 13.500 ns | 0.7400 ns | 0.0076 | 48 B |
| EmptyApiLink | 7.932 ns | 12.038 ns | 0.6598 ns | 0.0115 | 72 B |
| EmptyApiMediaType | 9.712 ns | 38.293 ns | 2.0990 ns | 0.0089 | 56 B |
| EmptyApiOAuthFlow | 5.992 ns | 16.501 ns | 0.9044 ns | 0.0089 | 56 B |
| EmptyApiOAuthFlows | 5.611 ns | 6.006 ns | 0.3292 ns | 0.0089 | 56 B |
| EmptyApiOperation | 73.808 ns | 105.669 ns | 5.7921 ns | 0.0598 | 376 B |
| EmptyApiParameter | 9.987 ns | 52.942 ns | 2.9019 ns | 0.0153 | 96 B |
| EmptyApiPathItem | 7.261 ns | 47.687 ns | 2.6139 ns | 0.0102 | 64 B |
| EmptyApiPaths | 71.777 ns | 153.840 ns | 8.4325 ns | 0.0395 | 248 B |
| EmptyApiRequestBody | 6.336 ns | 15.158 ns | 0.8309 ns | 0.0076 | 48 B |
| EmptyApiResponse | 6.722 ns | 25.357 ns | 1.3899 ns | 0.0102 | 64 B |
| EmptyApiResponses | 69.793 ns | 73.649 ns | 4.0369 ns | 0.0395 | 248 B |
| EmptyApiSchema | 15.572 ns | 12.622 ns | 0.6918 ns | 0.0650 | 408 B |
| EmptyApiSecurityRequirement | 14.110 ns | 49.363 ns | 2.7058 ns | 0.0166 | 104 B |
| EmptyApiSecurityScheme | 5.967 ns | 2.491 ns | 0.1366 ns | 0.0140 | 88 B |
| EmptyApiServer | 8.528 ns | 34.590 ns | 1.8960 ns | 0.0076 | 48 B |
| EmptyApiServerVariable | 7.021 ns | 18.579 ns | 1.0184 ns | 0.0076 | 48 B |
| EmptyApiTag | 6.213 ns | 17.442 ns | 0.9561 ns | 0.0076 | 48 B |
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|---------------------------- |-------------:|----------:|----------:|-------:|----------:|
| EmptyApiCallback | 9.530 ns | 3.544 ns | 0.1942 ns | 0.0019 | 32 B |
| EmptyApiComponents | 16.342 ns | 13.284 ns | 0.7281 ns | 0.0062 | 104 B |
| EmptyApiContact | 14.826 ns | 7.392 ns | 0.4052 ns | 0.0029 | 48 B |
| EmptyApiDiscriminator | 11.966 ns | 24.387 ns | 1.3367 ns | 0.0024 | 40 B |
| EmptyDocument | 1,100.509 ns | 52.317 ns | 2.8677 ns | 0.0668 | 1136 B |
| EmptyApiEncoding | 8.472 ns | 4.256 ns | 0.2333 ns | 0.0033 | 56 B |
| EmptyApiExample | 8.204 ns | 2.671 ns | 0.1464 ns | 0.0033 | 56 B |
| EmptyApiExternalDocs | 14.383 ns | 7.357 ns | 0.4033 ns | 0.0024 | 40 B |
| EmptyApiHeader | 8.423 ns | 4.947 ns | 0.2712 ns | 0.0048 | 80 B |
| EmptyApiInfo | 19.354 ns | 2.912 ns | 0.1596 ns | 0.0048 | 80 B |
| EmptyApiLicense | 9.103 ns | 2.892 ns | 0.1585 ns | 0.0029 | 48 B |
| EmptyApiLink | 15.344 ns | 8.632 ns | 0.4732 ns | 0.0043 | 72 B |
| EmptyApiMediaType | 13.353 ns | 5.876 ns | 0.3221 ns | 0.0033 | 56 B |
| EmptyApiOAuthFlow | 16.937 ns | 23.422 ns | 1.2839 ns | 0.0033 | 56 B |
| EmptyApiOAuthFlows | 13.194 ns | 23.322 ns | 1.2783 ns | 0.0033 | 56 B |
| EmptyApiOperation | 70.995 ns | 17.112 ns | 0.9380 ns | 0.0224 | 376 B |
| EmptyApiParameter | 18.672 ns | 10.753 ns | 0.5894 ns | 0.0057 | 96 B |
| EmptyApiPathItem | 18.164 ns | 8.096 ns | 0.4438 ns | 0.0038 | 64 B |
| EmptyApiPaths | 63.171 ns | 1.055 ns | 0.0578 ns | 0.0148 | 248 B |
| EmptyApiRequestBody | 13.143 ns | 8.962 ns | 0.4913 ns | 0.0029 | 48 B |
| EmptyApiResponse | 7.853 ns | 1.278 ns | 0.0700 ns | 0.0038 | 64 B |
| EmptyApiResponses | 62.085 ns | 8.772 ns | 0.4808 ns | 0.0148 | 248 B |
| EmptyApiSchema | 19.546 ns | 4.037 ns | 0.2213 ns | 0.0244 | 408 B |
| EmptyApiSecurityRequirement | 15.817 ns | 4.579 ns | 0.2510 ns | 0.0062 | 104 B |
| EmptyApiSecurityScheme | 13.738 ns | 25.244 ns | 1.3837 ns | 0.0052 | 88 B |
| EmptyApiServer | 18.163 ns | 24.685 ns | 1.3531 ns | 0.0033 | 56 B |
| EmptyApiServerVariable | 15.036 ns | 23.813 ns | 1.3053 ns | 0.0029 | 48 B |
| EmptyApiTag | 13.712 ns | 6.139 ns | 0.3365 ns | 0.0029 | 48 B |
Loading