forked from microsoft/OpenAPI.NET
-
Notifications
You must be signed in to change notification settings - Fork 0
Add deviceAuthorizationUrl field to OAuthFlow object for OpenAPI 3.2.0 support #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baywet
merged 11 commits into
feat/oai-3-2-support
from
copilot/fix-df8b3b6b-3cac-4fec-9202-099f3cefe3c5
Sep 30, 2025
Merged
Add deviceAuthorizationUrl field to OAuthFlow object for OpenAPI 3.2.0 support #29
baywet
merged 11 commits into
feat/oai-3-2-support
from
copilot/fix-df8b3b6b-3cac-4fec-9202-099f3cefe3c5
Sep 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished work on behalf of
baywet
September 30, 2025 18:26
baywet
requested changes
Sep 30, 2025
src/Microsoft.OpenApi/Reader/V3/OpenApiOAuthFlowDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Reader/V31/OpenApiOAuthFlowDeserializer.cs
Outdated
Show resolved
Hide resolved
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
baywet
September 30, 2025 20:19
- Added DeviceAuthorizationUrl property to OpenApiOAuthFlow model - Added DeviceAuthorizationUrl constant to OpenApiConstants - Updated serialization logic: - For OpenAPI 3.2: serializes as "deviceAuthorizationUrl" - For OpenAPI 3.1 and 3.0: serializes as "x-oai-deviceAuthorizationUrl" (extension) - Updated deserialization logic for V32, V31, and V3 deserializers - Updated copy constructor to include DeviceAuthorizationUrl - Added tests for serialization in all versions (V3.0, V3.1, V3.2) - Added tests for deserialization in all versions (V3.0, V3.1, V3.2) - Updated PublicApi.approved.txt with new public API members - Ran performance benchmarks and included updated results Co-authored-by: baywet <[email protected]>
…3.1 & 3.2 Signed-off-by: Vincent Biret <[email protected]>
a7d0c35
to
1542284
Compare
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…b6b-3cac-4fec-9202-099f3cefe3c5
…ec-9202-099f3cefe3c5
baywet
approved these changes
Sep 30, 2025
kilifu
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Plan for deviceAuthorizationUrl in OAuthFlow
Summary
Successfully implemented the
deviceAuthorizationUrl
field for the OAuthFlow object as defined in OpenAPI 3.2.0 specification. The implementation includes:DeviceAuthorizationUrl
property toOpenApiOAuthFlow
classDeviceAuthorizationUrl
constant toOpenApiConstants
deviceAuthorizationUrl
(standard field)x-oai-deviceAuthorizationUrl
(extension with prefix)All tests pass (901 tests in Microsoft.OpenApi.Tests, 331 in Readers.Tests, 54 in Hidi.Tests), and performance benchmarks have been run and included in the commit.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.