-
Notifications
You must be signed in to change notification settings - Fork 24
Specialize residue names #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you've added hydrogens to a structure, this supports the full information present in the `residuedata` tables imported from ff19SB: - renames HIS to one of HID/HIE/HIP (using the protonation state from the added hydrogens) - renames the amino- and carboxyl-terminal residues by prepending `N`/`C`
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 95.28% 95.15% -0.13%
==========================================
Files 14 14
Lines 2141 2169 +28
==========================================
+ Hits 2040 2064 +24
- Misses 101 105 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let me know if there's some better place to put this new test file. |
jgreener64
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just one comment then feel free to merge.
I will tag a release after merge.
|
Should I move the data file to https://github.com/BioJulia/BioFmtSpecimens? |
|
You could if it provides a useful general case, but I'm not sure it's worth the effort. |
|
Just to let you know, I renamed the function to |
If you've added hydrogens to a structure, this supports the full information present in the
residuedatatables imported from ff19SB:N/C