Skip to content

Conversation

@timholy
Copy link
Collaborator

@timholy timholy commented Sep 17, 2025

If you've added hydrogens to a structure, this supports the full information present in the residuedata tables imported from ff19SB:

  • renames HIS to one of HID/HIE/HIP (using the protonation state from the added hydrogens)
  • renames the amino- and carboxyl-terminal residues by prepending N/C

If you've added hydrogens to a structure, this supports the full
information present in the `residuedata` tables imported from ff19SB:
- renames HIS to one of HID/HIE/HIP (using the protonation state from
  the added hydrogens)
- renames the amino- and carboxyl-terminal residues by prepending
  `N`/`C`
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.15%. Comparing base (98bfd75) to head (f548ea1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/model.jl 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   95.28%   95.15%   -0.13%     
==========================================
  Files          14       14              
  Lines        2141     2169      +28     
==========================================
+ Hits         2040     2064      +24     
- Misses        101      105       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timholy
Copy link
Collaborator Author

timholy commented Sep 17, 2025

Let me know if there's some better place to put this new test file.

Copy link
Member

@jgreener64 jgreener64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one comment then feel free to merge.

I will tag a release after merge.

@timholy
Copy link
Collaborator Author

timholy commented Sep 18, 2025

Should I move the data file to https://github.com/BioJulia/BioFmtSpecimens?

@jgreener64
Copy link
Member

You could if it provides a useful general case, but I'm not sure it's worth the effort.

@timholy timholy merged commit 3b4e96e into master Sep 18, 2025
8 of 10 checks passed
@timholy timholy deleted the teh/histidine branch September 18, 2025 17:04
@jgreener64
Copy link
Member

Just to let you know, I renamed the function to specializeresnames! to match the lack of underscores in the rest of the package. It's not a change I like, but I think consistency is best (I would do it differently if I started again today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants