Merged
Conversation
* Use cconvert instead of accessing the internal .ref field of Array. This is still not entirely stable API, but hopefully better * Do not use inbounds for substring of AbstractString, because the implementor of the AbstractString may lie about the codeunits, and I'm not confident the substring constructor will detect it * Use ncodeunits instead of reading the ncodeunit fields of substrings * Be slightly more conservative in what subarrays the constructor accepts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 96.83% 96.82% -0.02%
==========================================
Files 5 5
Lines 253 252 -1
==========================================
- Hits 245 244 -1
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subarray changes are technically breaking, but since the previous behaviour was buggy, AND the bug would throw an internal error, AND it's unlikely anyone relied on it, I'll add it in a minor release