t7a2 add search feature (desktop view) #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this PR @PhilReedData. I have some troubles with Safari and Chrome. The search box is not showing. And I get these errors in the console. |
Collaborator
|
I tried it in Chrome, Chromium, Edge, Firefox, DuckDuck from a Windows machine. No console issues except for Edge but the issues were related to the page loaded after search and not to the search itself |
Collaborator
|
@albangaignard are the console log issues still present? If not, could you please process this PR? If yes, could you please let us know so @PhilReedData can take a second look? Thanks. |
Collaborator
Author
|
I've run it again today in Safari, I don't have the problems you mention, @albangaignard. Could you please elaborate? 
Firefox is working for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ELIXIR Template Toolkit (ETT) search feature for the whole site. Works on desktop view. Hidden on mobile view for now as it obscures the site title (can be fixed when we have more time).
Also take out the Twitter box.