Skip to content

Allow tolerance in tests.#133

Open
plenaerts wants to merge 2 commits intoBioconductor:develfrom
plenaerts:devel
Open

Allow tolerance in tests.#133
plenaerts wants to merge 2 commits intoBioconductor:develfrom
plenaerts:devel

Conversation

@plenaerts
Copy link
Copy Markdown

Hi, in debian QA tests, we see an error on riscv64 architecture.
See https://ci.debian.net/packages/r/r-bioc-s4vectors/testing/riscv64/69538974/#L1763 for the error.

I propose the attached patch to fix this. Thanks for taking it in consideration.

Br,

Pieter

@hpages
Copy link
Copy Markdown
Contributor

hpages commented Mar 28, 2026

Thanks for the PR. Any reason not to use checkEqualsNumeric() like in the other checks where some tolerance is needed? I'd rather keep some consistence across the checks if possible.

@plenaerts
Copy link
Copy Markdown
Author

You're right. There is no good reason. I applied your suggestion. Should've used the more specific function in the first place. 🫣

@hpages
Copy link
Copy Markdown
Contributor

hpages commented Mar 29, 2026

Thanks. Can you confirm that the default value (.Machine$double.eps^0.5) for the tolerance argument is too strigent on the riscv64 arch, hence why you're explicitely setting the argument to 1e-6? Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants