Skip to content

Allow for distinct input types for create and update #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreachild wants to merge 1 commit into from
Closed

Allow for distinct input types for create and update #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions src/schemaModelValidator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions and limitations under the License.
*/

import { schemaStringify } from './schemaParser.js';
import { print } from 'graphql';
import { GraphQLID, print } from 'graphql';
import {gql} from 'graphql-tag'
import { loggerInfo, yellow } from "./logger.js";

Expand Down Expand Up @@ -139,18 +139,48 @@ function addNode(def) {
const idField = getIdField(def);

// Create Input type
typesToAdd.push(`input ${name}Input {\n${print(getInputFields(def))}\n}`);
const createFields = [];
for (const field of def.fields) {
if (isScalar(nullable(field.type))) {
if (field.type.kind === 'NonNullType' && field.type.type.name.value === GraphQLID.name) {
Copy link
Author

@andreachild andreachild May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use optional chaining to avoid reference errors:

field.type?.kind === 'NonNullType' && field.type?.type?.name?.value === GraphQLID.name

// make ID nullable by unwrapping the NonNullType from the field
const idFieldCopy = JSON.parse(JSON.stringify(field));
idFieldCopy.type = idFieldCopy.type.type;
createFields.push(idFieldCopy);
} else {
createFields.push(field);
}
}
}
typesToAdd.push(`input ${name}CreateInput {\n${print(createFields)}\n}`);

// Update Input type
const updateFields = [];
for (const field of def.fields) {
if (isScalar(nullable(field.type))) {
if (field.type.kind === 'NonNullType') {
// make non-nullable nullable by unwrapping the NonNullType from the field
const fieldCopy = JSON.parse(JSON.stringify(field));
fieldCopy.type = fieldCopy.type.type;
updateFields.push(fieldCopy);
} else {
updateFields.push(field);
}
}
}
typesToAdd.push(`input ${name}UpdateInput {\n${print(updateFields)}\n}`);

// Create query
queriesToAdd.push(`getNode${name}(filter: ${name}Input, options: Options): ${name}\n`);
queriesToAdd.push(`getNode${name}s(filter: ${name}Input): [${name}]\n`);

// Create mutation
mutationsToAdd.push(`createNode${name}(input: ${name}Input!): ${name}\n`);
mutationsToAdd.push(`updateNode${name}(input: ${name}Input!): ${name}\n`);
mutationsToAdd.push(`createNode${name}(input: ${name}CreateInput!): ${name}\n`);
mutationsToAdd.push(`updateNode${name}(input: ${name}UpdateInput!): ${name}\n`);
mutationsToAdd.push(`deleteNode${name}(${print(idFieldToInputValue(idField))}): Boolean\n`);

loggerInfo(`Added input type: ${yellow(name+'Input')}`);
loggerInfo(`Added input type: ${yellow(name+'CreateInput')}`);
loggerInfo(`Added input type: ${yellow(name+'UpdateInput')}`);
loggerInfo(`Added query: ${yellow('getNode' + name)}`);
loggerInfo(`Added query: ${yellow('getNode' + name + 's')}`);
loggerInfo(`Added mutation: ${yellow('createNode' + name)}`);
Expand Down
Loading